Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for backports #175

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 31, 2020

I'm not sure if configs for repositories are possible.
But if so it would make sense to allow that to be optional

Fix #156

Signed-off-by: Joas Schilling <[email protected]>
@skjnldsv skjnldsv requested a review from rullzer April 8, 2020 05:29
@skjnldsv
Copy link
Member

skjnldsv commented Apr 8, 2020

This seems a bit too much no?
There is no specific settings per repo as far as I know. If we switch to a dedicated github action for this we might be able to create a config there though

@nickvergessen
Copy link
Member Author

This seems a bit too much no?

For default yes, but in talk I'd rather like to be asked if something is okay to skip, because (especially in the current days) most fixes require backporting and the few features as false-positives are okay for me. Maybe we can have 2 backport bots? Or is that per org?

@skjnldsv
Copy link
Member

skjnldsv commented Apr 8, 2020

Or is that per org?

This is per org currently Is this really that big of an issue? DO you have to request that many backports?

@nickvergessen
Copy link
Member Author

I'll just leave this here: https://github.com/nextcloud/spreed/milestone/49?closed=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict mode aka. confirm "no backport needed"
2 participants