An email address label is not set if the address type is given twice

[j-ed]

Expected behavior

The Contacts app should show the correct email address label if the address type is given twice.

Current behavior

The contacts app shows an empty email address label.

Example:

EMAIL;TYPE=WORK,WORK,pref:[email protected]

** Result:**

Environment

Server Configuration

OS: Linux 3.16.63
Web server: Apache2 2.4.37
Database: MariaDB 10.2.22
PHP version: 7.2.14
Nextcloud version: 15.0.5
Contacts app version: 3.0.5

Client Configuration

Browser: Mozilla Firefox 66.0.2
Operating system: Windows 10

[nextcloud-bot]

GitMate.io thinks possibly related issues are #771 (add email address not possible if contact already has one or more email addresses), #1027 (ITEM2.xxx properties - the url label is not set at all), #1026 (ITEM2.xxx properties - the url label is not correctly set), #1028 (ITEM2.xxx properties - the phone number label is not correctly set), and #518 (CardDav types).

[skjnldsv]

EMAIL;TYPE=WORK,WORK,pref:[email protected]

I'm not sure I get it. You mean because there is two WORK types?
We should indeed have a repair step for this, as this is not valid 🤔

[j-ed]

That's my assumption, because several other entries are correctly displayed. Unfortunately I found several different ways how email address entry types have been formatted in my address book. All others seem to be correctly displayed. Here is the list:

EMAIL
EMAIL;TYPE="home,pref"
EMAIL;TYPE="work,pref"
EMAIL;TYPE=HOME
EMAIL;TYPE=HOME,PREF
EMAIL;TYPE=WORK
EMAIL;TYPE=WORK,PREF
EMAIL;TYPE=WORK,WORK,pref
EMAIL;TYPE=home
EMAIL;TYPE=home,pref
EMAIL;TYPE=work
EMAIL;TYPE=work,pref
EMAIL;TYPE=work;PREF=1

[skjnldsv]

Fix in #1042