-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning if contact contains unsupported properties #1045
Comments
@skjnldsv That's great news. Actually I don't have any other unsupported properties in mind, but maybe this warning could help to find out about any such unsupported property (if combined with a link to the issues here). What do you think? PS: The comma in the label does not prevent the address from showing, just from saving/editing the contact. |
@caugner we should probably add some kind of message yes. |
@skjnldsv I was thinking about something like this: Warning: This contact contains information that is not supported by Nextcloud Contacts. (Click for details)The contact [UUID] was originally created using [PRODID].
If you think this is a bug, please report an issue here. |
@jancborchardt thoughts? :) |
Why show a warning, we could just show it just like in @caugner’s left screenshot of Android contacts? :) |
@jancborchardt I don't understand, you mean support the properties? |
If it’s a custom property, say "Telekom" for the phone number, or the "Emergency only" for the mail address, we could simply read that out and use it as the custom label? |
@jancborchardt Meanwhile those custom labels are supported (#42). |
@caugner so is this issue resolved, or what is left to do? Sorry if I’m a bit confused. :D |
The issue remains for other unsupported property (that we may not know yet). Especially if the app does not show any [supported] properties for a contact, I would like to be sure (as a user) that I can delete that user without losing any data. Right now, I cannot be, as there could be unsupported properties that the app doesn't show me and that I'm not aware of. |
Yes, the issue is on all the props that are unsupported :) |
So could you give some examples of potentially unsupported properties and how they would look in the vCard? E.g. which of the rows in your example above. :) |
@jancborchardt look at that mess: https://en.wikipedia.org/wiki/VCard#vCard_extensions We should have a warning saying 'A property named X-WEBMONEY-ID is present but not understood by the contacts app, ignoring it', or whatever message that have relevance in that situation :) |
If we knew what vCard properties there are out there that Nextcloud Contacts doesn't support yet, we could just decide to implement them or not, but the issue I see is that new (inofficial) vCard properties may popup without us realising. PS: Do we really already display all the properties listed here: https://de.wikipedia.org/wiki/VCard#Spezifikation (at least I don't find |
@skjnldsv what we can simply do is a workaround for all the ones we don’t understand:
Wouldn’t that work? |
We would have no idea what the content is. It could be nonsense, it could be a date, a string, an array... anything. We cannot display them! 😁 |
Right, sorry I’m getting ahead of myself. :) For me any kind of warning is clearly a non-solution. That’s why I asked:
And I would wager that we can find some way of displaying which works with any potentially unsupported vCard and just displays these things in a semi-meaningful way. |
Sure, but it's also very error-prone. I don't want to add any kind of similar solutions. 😉 |
So, we don’t do anything then? :) Again, I just need a list of examples and I could show you how it works. Like taking some from https://en.wikipedia.org/wiki/VCard#vCard_extensions:
We can just straight up not show the prefixes for This would not change the data, it would only be the way it is displayed in the web interface. So it wouldn’t cause permanent issues whatsoever. |
@jancborchardt and I will then get an anthology of issues asking why the field that appear on nextcloud does not appear on iOS or Android? The vcard standard is pretty strict for that reason, because people created a mess with custom properties and turned a basic data set into the wild wild west! 🤠 |
Also, I would make the analogy to css proprietary properties. |
Aaah ok it does not show on iOS or Android either? Is there any app which shows it then? If no app shows it, then we don’t need to do that either of course – not even with a warning. Sorry but I don’t know all about this stuff. :D |
@jancborchardt don't be sorry, the vcard is a real nightmare sometimes. |
I'd say either:
But a warning is not a good way to go. It's basically saying "we know this is wrong but we decided to not do anything about it and now we're even telling you". ;) |
@caugner thoughts? :) |
Yes, I think we should not do that. Let's either support custom ones that are widely used, or ignore others. Too much risk of data corruption, and we cannot start supporting custom properties that no one knows about :) |
Does it currently display a warning? I ask because if it does not, I believe that this should be reconsidered - regardless of whether the data is retained, if I were to import contacts whose properties were retroactively silently inaccessible unless exported, this would be seriously annoying, because I may well have put some effort into migration which would be rendered useless. Apologies for the question if it does warn the user. |
Is your feature request related to a problem? Please describe.
Recently, I accidentally deleted contacts that appeared to be empty in Nextcloud Contacts (no phone number, no email, no address). However, as it turned out, these contacts actually had phone numbers and addresses attached, just in a not yet supported format with custom types (cf. #42):
Android 8.1 Contacts vs. Nextcloud Contacts 3.0.5:
PS: Due to the commas in the
LABEL
, this contact cannot currently be edited in Nextcloud Contacts (cf #1009).Describe the solution you'd like
If a contact contains unsupported (i.e. unexpected) properties, Nextcloud Contacts should show a warning (possibly extendable to reveal the raw lines).
Describe alternatives you've considered
I cannot think of any alternative right now.
Additional context
Those contacts were created on Android 8.1 using the default Contacts app and synchronized using DAVx⁵.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: