-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently not possible to download group of contacts. #39
Comments
#43 only restores the export functionality - downloading specific groups separately is still not supported |
Oooh, sorry, you meant groups, I was thinking of addressbooks :( |
:-) Indeed. Selecting a contact group to download. (And multiple addresses or groups, I guess for completeness). I'm really missing it now I have to do my Christmas cards again.. But I see where you are coming from, didn't know that functionality had disappeared too. |
Hello, can you comment why this issue is closed? Today I started my christmas card address list. I have a group for that in Nextcloud and it seems it is still not possible to download that group seperately. I now have to download my whole addressbook and script a filter. |
@brjhaverkamp this issue is not closed! :) |
This will require a php script from the server to filter out vcards or generate a single file from multiple vcards, should be straightforward though. |
Sounds good. 3.0? :-) |
@brjhaverkamp Not enough time available! |
If you can point me at where I could integrate this, I could have a stab at it. Not in the coming weeks.(just started a new job) But christmas-card-season is slowly approaching, so around that time I have my yearly focus on the contacts app. |
Sure! :) The vcf addressbook export is an official plugin, so you cannot edit it on nextcloud, but the source is available as inspiration: https://github.com/nextcloud/3rdparty/blob/master/sabre/dav/lib/CardDAV/VCFExportPlugin.php The idea would be to allow to pass data to the ?export request on an addressbook to request a set of vcard? But this will only allow download by addressbook (which is fine, 99% of our users uses 1 addressbook, and we can trigger multiple requests depending on the addressbooks od the contacts I guess) |
Hi, I just added a pull request for that. Please review and let me know, if that is acceptable! |
Okay. Here are some architectural thoughts and ideas:
Well, is that more or less what we want, or do I absolutely not get it? |
@charismatic-claire I started yesterday implementing the plugin! :)
I would rather have a POST that takes an array of vcf url to be downloaded.
Apparently also on |
Wow, making a PR to the "server" project seem to get the attention of quite some people. I'm impressed by the amount of feedback you already got. I'll review your code as well... Thank's a lot for pushing things forward. |
@charismatic-claire Thanks!! We're a bit stuck regarding the GET/POST request. |
@skjnldsv I will update my PR as soon as possible... Thank you for your work and your encouragement. I learned a lot. |
@charismatic-claire awesome! |
Alright. So let's make a little plan first. What do we wanna do? Shall I just add download links to every group, so we can download it and that's it? Or do we wanna go for more? In case we wanna go for more, I need a little bit more information. If you want, say download 2 groups at the same time, you would need a way to first select which groups you wanna download and then trigger the download. How would that look like? You could set "download checkmarks" first and trigger the download later on by clicking a button? Where would that button be? If you wanna make a search or a manual selection of contacts to download, how would you first select and later on trigger the download? I'm not talking about the implementation, I'm talking about the interface design here. Personally I would prefer to just add a download button to each group, like I did before. Only this time, I'll utilize the recently added capabilities of the backend. But I'm not sure if @skjnldsv would accept such a pull request. My understanding is... he wouldn't. So let's talk about it ;-) |
I would say, let's do it step by step! :) One issue is that we can have groups across multiple addressbooks, so we'll have to trigger as many REPORT as there are addressbooks. I'll let you figure out, this is just a matter of sorting the proper data and triggering the proper REPORT and download I guess :) I'm completely fine with the download button for each group.
Let's see that for the 3.1.0 version ;) |
Great. I like that. So let's do it. I'll let you know if I have something to show... |
…it shows my idea..." This reverts commit ae8245c.
…contacts." This reverts commit 78c8afe.
…tigetExport()' from 'cdav-library'
Yeah, I implemented a new version of this feature, using the |
…tup." This reverts commit ba3dbd3.
…ownload-contact-group-#39 Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
…ownload-contact-group-nextcloud#39 Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Hello Charismatic-clair, While you are on a roll with the contacts app of Nextcloud and this great improvement in issue 37, could I ask you to take a look at issue #42? |
At the moment it is not possible to select a single group of contacts and export/download it as a vcard file.
This used to be possible with the older contact app (last year)
Can this feature be re-added again?
Regards,
Bert
The text was updated successfully, but these errors were encountered: