Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two address fields are connected after adding a phone number #803

Closed
violoncelloCH opened this issue Dec 30, 2018 · 2 comments
Closed

two address fields are connected after adding a phone number #803

violoncelloCH opened this issue Dec 30, 2018 · 2 comments
Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Milestone

Comments

@violoncelloCH
Copy link
Member

violoncelloCH commented Dec 30, 2018

Describe the bug

For a contact with e.g. a home and a work address, after adding or removing a phone number entry, these two addresses are connected and typing into one of them simultaneously changes the other one. (You are actually just changing one of them, regardless in which one you type, only one of them is overwritten, you just can't edit / see the other address until you make a browser refresh.)

To Reproduce

  1. Go to a contact entry with two addresses (e.g. work and home)
  2. Add a new "Phone" field or remove one
  3. See the two addresses displaying the same values and on typing both of the addresses
  4. type in one of the addresses and see the other one changing at the same time

Expected behavior
both addresses should still be correctly displayed and you should be able to edit both of them independently

Actual behavior
the two addresses are synchronised and you therefore can't see the other address (because one of them overwrites the other)

Screenshots
image001

Server configuration

Operating system: Linux

Web server: Apache

Database: MariaDB

PHP version: 7.2

Nextcloud version: 15.0.0

Contacts version: 3.0.1

Signing status:

No errors have been found.

Client configuration

Browser: Firefox 64.0

Operating system: Win 10 / Ubuntu 18.10

@violoncelloCH violoncelloCH added bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Dec 30, 2018
@violoncelloCH violoncelloCH added this to the 3.0.2 milestone Dec 30, 2018
@nextcloud-bot

This comment has been minimized.

@nextcloud-bot nextcloud-bot removed the 1. to develop Accepted and waiting to be taken care of label Dec 30, 2018
@violoncelloCH violoncelloCH added the 1. to develop Accepted and waiting to be taken care of label Dec 30, 2018
@skjnldsv skjnldsv added the high High priority label Dec 31, 2018
@skjnldsv
Copy link
Member

skjnldsv commented Dec 31, 2018

An issue with the vuejs local data indeed!
Nice catch! 👍

https://forum.vuejs.org/t/data-properties-based-on-props-are-not-re-evaluated-when-props-change/21085/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Development

No branches or pull requests

3 participants