Cannot see Date of Death to existing contacts #813
Comments
|
GitMate.io thinks possibly related issues are #781 (Can not add "Date of Death" to contacts), #452 (Can't add new contact), #580 (Unable to add, remove or change contact entries), #507 (Contact could not be saved if both birthday and date of birth given), and #794 (Birthday, Date of Death, Anniversary save wrong date). |
This comment has been minimized.
This comment has been minimized.
|
@JC5 Thanks for your report! Unfortunately I cannot reproduce your bug. I can add the date of death properly here. How to access your browser console (Click to expand)Chrome
Safari
IE9
Firefox
Opera
|
|
I can add the field to a contact who hasn't yet has the DoD. But a contact that has the DoD already, I get this: Full logs: The DoD is not visible and I can't add it. |
|
Thanks, I will investigate! |
|
Hello @JC5 |
|
I'll check at home, but have to upgrade first as well. 👍 |
|
OK, I am still getting this problem. For contacts that have a birthday, I cannot add a Date of Death. Screenshots: https://imgur.com/a/p9iBbcZ Error in console: I am not sure what you would like to know from the installation itself, and I find the bug template to be a pain in the butt. So just the basics: PHP 7.2, Nextcloud 15.0.2, Contacts 3.0.3, Firefox 65.0 on macOS Mojave. Let me know how I can help! |
|
@JC5 Thanks! I'm guessing one of your contact have an improper value. :) |
|
Yes, I do. Just let me know what I need to do. |
|
With the help of #912 I can now see the issue. @j-ed the DEATHDATE on your contact have a colon instead of a semi-colon: EDIT: the library we're using seems to be misbehaving. Issue reported here: kewisch/ical.js#379 |
skjnldsv
added
blocked
|
This is the full card, as I've downloaded it from Nextcloud. This is the original from Google. As you can see, I fixed the date of birth in the meantime. |
|
The Google format seems to be the same as on an iPhone, except that the date stamp is formatted differently. I wouldn't have been thought that standards could be interpreted in so many different ways. |
|
@JC5 this confirm that this is the same bug! |
|
@j-ed the contact you paste properly display the deathdate on your iOS device? 🤔 |
|
Oh no, sorry for the confusion. I added that layout only because I want to show the similarity of the Google and iPhone format in this case, so that you can cover both in one go. If I create a contact record in Nextcloud and sync it to an iPhone 12.x, none of the two fields birth and death date are shown. This how the record looks like after it has been created in Nextcloud:
This is what is being displayed on the iPhone if I access the contact (both dates are missing):
|
|
@j-ed okay, what does an iOS created vcf file looks like on nextcloud? |
|
Here is the card generated by my phone for the contact I shared. I sync with nextcloud only. |
|
@skjnldsv Here we go. This is a contact I've created on the iOS device:
This is how the sync'ed contact in Nextcloud looks like (death date is missing)
This is the vcf-file of the sync'ed contact exported from Nextcloud: |
|
I'm seeing similar things. The Totestag you have is some kind of a custom event. I was able to create cards with a multiple of those using Google Contacts: I am getting the impression that the date format (xxxx-xx-xx or xxxxxxxx) does not matter much. In either case, this card will give the "t.localValue.toJSDate is not a function" error: Note that the date formats can be both 2013-01-01 and 20130101. The error occurs in both instances. Creating a NEW card with a birthday and a death day can be downloaded from nextcloud in this format:
So first I tried pushing this: That gives interesting results:
Adding dashes seems to help!
The best way to satisfy both iOS and Nextcloud is this format: This fixes the problem in Nextcloud, and allows iPhone to show the custom event "Overlijden". |
|
Okay, i'm very confused now. Is it just a compatibility issue because iOS uses ABDATE properties? Or ware we still only on the |
|
After updating the Contacts app to v3.0.4 the situation has slightly changed. The birthday is now displayed in the web gui, but not the death date anymore. On an iPhone the death date is now displayed as a normal date. In my test account the following details are listed. Surprisingly the date field has been stored twice: |
|
Okay, so to recap a bit, because this is confusing now 😝
What do you mean by that? |
|
Originally the contact record only contained a birth and a death date field. Due to the fact that the death date field seems not to be used on all environments and the date format is different on an iPhone (ybcu9b.X-...), the date record has now been duplicated and exists twice. |
that's what I don't get. If I add a date of death it properly appear on mine! 🤷♀️ |
|
@skjnldsv Yes, that's what you get if you add the field to a new record and what is still working. I can confirm that I can fix the problem by deleting and manually recreating the record, but |
|
Now I get it! Sorry for that! :) Fix is in #988 |
skjnldsv
changed the title
|
Can I download the modified package somewhere or do I have to wait for the nightly build? |
|
Oups sorry! Here: |
|
I can confirm that the death date is correctly displayed again after installing the new version. |
|
@j-ed awesome! Thanks :) |
|
I had the same issue. The contacts.tar.gz you provided above worked. Problematic VCF DEATHDATE property: New DEATHDATE property as inserted by the new contacts app. Would there be any way to auto-correct such dates? |
|
@raoulbhatia I think a check could fix the invalid data. Something like this: export default {
name: 'deathdate without value property',
run: contact => {
return contact.vCard.hasProperty('deathdate')
&& !contact.vCard.getFirstProperty('deathdate').hasProperty('value');
},
fix: contact => {
contact.vCard.addPropertyWithValue('value', 'date');
return true;
}
} |
|
Well, the value is not forced according to the rfc and might works on others vcard utilities. So I'm not sure we want to fix them if they're not really incompatible nor invalid! 🤔 |
Describe the bug
I cannot add the "Date of death" to any of my contacts.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I see Date of Death
Actual behavior
It's not there.
Screenshots
Server configuration
Operating system: Linux
Web server: Apache
Database: MySQL
PHP version: 7.2
Nextcloud version: 15.0.0
Contacts version: 3.0.1
Updated from an older Nextcloud or fresh install: Updated from 14
Signing status:
List of activated apps:
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: