Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.3] Year range in the date select dialog is always one year ahead of the available options. #911

Closed
j-ed opened this issue Feb 3, 2019 · 7 comments
Labels
blocked Waiting for a fix on one of our dependencies design Related to the design

Comments

@j-ed
Copy link

j-ed commented Feb 3, 2019

Expected behavior

The displayed year range in the date select dialog of birth or death day fields should reflect the available options.

Current behavior

The displayed year range in the date select dialog of birth or death day fields is always one year ahead of the available options.

20190203_nc_contacts_date_selector

Steps to reproduce

  1. Open the Contacts app.
  2. Add a birthday.
    -> Check out the displayed year range.

Environment

Server Configuration

OS: Linux 3.16.60
Web server: Apache2 2.4.37
Database: MariaDB 10.2.19
PHP version: 7.2.14
Nextcloud version: 15.0.2
Contacts app version: 3.0.3

Client Configuration

Browser: Mozilla Firefox 65.0
Operating system: Windows 10

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #596 (Contacts 3.0.0), #903 ([3.0.3] Unable to close the settings dialog in the Contacts app), #840 (Can´t select birthday - invalid date), #841 (contacts app 3.0.1 sets wrong date), and #240 (Option Select picture from Nextcloud).

@skjnldsv
Copy link
Member

skjnldsv commented Feb 4, 2019

@j-ed Hey!
We're using the vue2-datepicker library for that.
I think this is built on the design. Could you open the issue there? :)

@j-ed
Copy link
Author

j-ed commented Feb 4, 2019

@skjnldsv [x] done.

@skjnldsv skjnldsv closed this as completed Feb 4, 2019
@skjnldsv skjnldsv added the invalid This doesn't seem right label Feb 4, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Feb 4, 2019

Issue in mengxiong10/vue2-datepicker#245
Thanks a lot @j-ed 🤗

@skjnldsv skjnldsv added design Related to the design blocked Waiting for a fix on one of our dependencies and removed invalid This doesn't seem right labels Feb 4, 2019
@skjnldsv skjnldsv reopened this Feb 4, 2019
@j-ed
Copy link
Author

j-ed commented Feb 10, 2019

@skjnldsv I just got the information that version 2.9.2 of vue2-datepicker has been published which fixes the problem.

@skjnldsv
Copy link
Member

@j-ed same! Let's merge nextcloud-libraries/nextcloud-vue#242 and then trigger a release

@skjnldsv
Copy link
Member

Fixed in a6722de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting for a fix on one of our dependencies design Related to the design
Projects
None yet
Development

No branches or pull requests

3 participants