Add systemd user service #3510

Tachi107 · 2021-07-03T20:06:54Z

Closes #728

I didn't know where to put the systemd unit, so I created a systemd/ directory. Let me know if there is a more appropriate place :)

Edit: forgot to mention that I've obviously tested this, and (on my Debian 11 pc) everything works as expected

FlexW · 2021-07-12T14:50:43Z

I just wanted to throw in that this might not play nice with the autostart file that we provide. If the user disables autostart in the application, and has the systemd file installed, the settings from the gui get not respected anymore. That may confuse users.

EDIT: Btw you can use dex to autostart applications that provide a autostart file, if you don't use a DE like GNOME or KDE. I do that on i3.

Tachi107 · 2021-07-12T15:17:44Z

I just wanted to throw in that this might not play nice with the autostart file that we provide. If the user disables autostart in the application, and has the systemd file installed, the settings from the gui get not respected anymore. That may confuse users.

I agree, the UI is completely unaware of the systemd unit, but it is also true that having the unit installed does not cause the service to start, so unless the user manually runs systemctl --user enable nextcloud-desktop nothing strange should happen.

Syncing the UI and the systemd unit would be nice though

Tachi107 · 2021-07-12T15:30:05Z

I just noticed that running Nextcloud through systemd causes some minor issues; the client does not respect GTK settings like icon theme, font, etc (see screenshot).

Nothing that would cause serious problems, but I would prefer to first fix that issues and then let you merge this. Sorry for not noticing earlier :) (this also says a lot about the severity of the issue)

Tachi107 · 2021-07-12T17:45:42Z

This looks like a Qt issue, as running GTK apps through systemd does not cause any issue, while apps like qbittorrent suffer from the same problem.

If anyone has any suggestion it would be much appreciated :)

mgallien · 2021-07-15T10:17:12Z

This looks like a Qt issue, as running GTK apps through systemd does not cause any issue, while apps like qbittorrent suffer from the same problem.

If anyone has any suggestion it would be much appreciated :)

I guess you will want to modify Wants=network-online.target to be launched once the desktop environment is launched such that env variables are set and allow getting the proper style
one guess it to use graphical-session.target but I am not sure

Tachi107 · 2021-07-15T13:19:31Z

I guess you will want to modify Wants=network-online.target to be launched once the desktop environment is launched such that env variables are set and allow getting the proper style

That's the same thing I thought, but it seems that it doesn't solve the issue. Even manually restarting the service after the system is fully booted does nothing.

mgallien · 2021-07-16T13:10:47Z

I guess you will want to modify Wants=network-online.target to be launched once the desktop environment is launched such that env variables are set and allow getting the proper style

That's the same thing I thought, but it seems that it doesn't solve the issue. Even manually restarting the service after the system is fully booted does nothing.

I will have another look soon unless somebody is faster than me

mgallien · 2022-06-22T09:28:19Z

@Tachi107 I am really sorry for the lack of followup from me on this one
going to test it and see if I can get it merged

Signed-off-by: Andrea Pappacoda <[email protected]>

Tachi107 · 2022-06-22T09:31:20Z

Don't worry :)
I've been using this for quite a while now, and apart from the minor issues I mentioned before I did not encounter any other problems

nextcloud-desktop-bot · 2022-06-22T09:34:21Z

AppImage file: Nextcloud-PR-3510-394c89d50ed0abd4955957cc69bb976fca037819-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

codecov · 2022-06-22T09:55:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.42%. Comparing base (af93a98) to head (394c89d).
Report is 4703 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3510      +/-   ##
==========================================
- Coverage   56.42%   56.42%   -0.01%     
==========================================
  Files         138      138              
  Lines       17071    17071              
==========================================
- Hits         9633     9632       -1     
- Misses       7438     7439       +1

see 1 file with indirect coverage changes

mgallien · 2023-07-04T08:35:09Z

systemd/nextcloud-desktop.service.in

+Wants=network-online.target
+
+[Service]
+ExecStart=@bindir@/nextcloud --background


executable name is defined as a variable in cmake files
please replace this by this variable APPLICATION_EXECUTABLE

mgallien

see my other comments
for the context
when developing the Nextcloud client, I run in parallel the latest official AppImage binary
so to be able to run my self built desktop client, I make changes to NEXTCLOUD.cmake to not conflict with the already running client

mgallien · 2023-07-04T08:59:28Z

CMakeLists.txt

+    option(INSTALL_SYSTEMD "Install systemd user service" ON)
+    if(INSTALL_SYSTEMD)
+        set(bindir ${CMAKE_INSTALL_FULL_BINDIR})
+        configure_file(systemd/nextcloud-desktop.service.in ${CMAKE_CURRENT_BINARY_DIR}/nextcloud-desktop.service)


instead of nextcloud-desktop please use this cmake variable LINUX_APPLICATION_ID
that is already in use with the .desktop file generation (https://github.com/nextcloud/desktop/blob/master/src/gui/CMakeLists.txt#L732)

mgallien · 2023-07-04T09:02:27Z

systemd/nextcloud-desktop.service.in

+# SPDX-License-Identifier: GPL-2.0-or-later
+
+[Unit]
+Description=Nextcloud desktop user service


please replace Nextcloud by this variable from cmake APPLICATION_NAME

mgallien · 2025-02-13T08:17:30Z

@Tachi107 gentle ping
could you have a look at the requested changes ?
without a reply from you I would take over the PR and create a branch cherry-picking your commit
in any case, thanks for the contribution

Tachi107 · 2025-02-13T10:37:14Z

Oh yeah, sure, don't be afraid to ping. I most likely forgot about this. I'll take a look later today :) Il 13 febbraio 2025 09:17:53 CET, Matthieu Gallien ***@***.***> ha scritto:

…

mgallien left a comment (nextcloud/desktop#3510) @Tachi107 gentle ping could you have a look at the requested changes ? without a reply from you I would take over the PR and create a branch cherry-picking your commit in any case, thanks for the contribution

thomasmerz · 2025-02-14T08:33:07Z

Just as a hint… maybe you might want to have a look at how Syncthing is dealing this!?

$ systemctl status syncthing*|ack Synct
● [email protected] - Syncthing - Open Source Continuous File Synchronization for user1
● [email protected] - Syncthing - Open Source Continuous File Synchronization for user2

mgallien added the 2. to review label Jul 12, 2021

Add systemd user service

394c89d

Signed-off-by: Andrea Pappacoda <[email protected]>

mgallien force-pushed the systemd-user-service branch from 7e2afda to 394c89d Compare June 22, 2022 09:28

claucambra approved these changes Jun 21, 2023

View reviewed changes

mgallien requested changes Jul 4, 2023

View reviewed changes

jospoortvliet mentioned this pull request Jan 13, 2024

Include a simple systemd service with the client #728

Open

Rello added 3. to review and removed 2. to review labels Nov 28, 2024

Rello assigned claucambra Dec 3, 2024

Rello added this to the 3.16.0 milestone Dec 3, 2024

camilasan modified the milestones: 3.16.0, 3.17.0 Feb 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add systemd user service #3510

Add systemd user service #3510

Tachi107 commented Jul 3, 2021 •

edited

Loading

FlexW commented Jul 12, 2021 •

edited

Loading

Tachi107 commented Jul 12, 2021

Tachi107 commented Jul 12, 2021

Tachi107 commented Jul 12, 2021

mgallien commented Jul 15, 2021

Tachi107 commented Jul 15, 2021

mgallien commented Jul 16, 2021

mgallien commented Jun 22, 2022

Tachi107 commented Jun 22, 2022

nextcloud-desktop-bot commented Jun 22, 2022

codecov bot commented Jun 22, 2022 •

edited

Loading

mgallien Jul 4, 2023

mgallien left a comment

mgallien Jul 4, 2023

mgallien Jul 4, 2023

mgallien commented Feb 13, 2025

Tachi107 commented Feb 13, 2025 via email

thomasmerz commented Feb 14, 2025

Add systemd user service #3510

Are you sure you want to change the base?

Add systemd user service #3510

Conversation

Tachi107 commented Jul 3, 2021 • edited Loading

FlexW commented Jul 12, 2021 • edited Loading

Tachi107 commented Jul 12, 2021

Tachi107 commented Jul 12, 2021

Tachi107 commented Jul 12, 2021

mgallien commented Jul 15, 2021

Tachi107 commented Jul 15, 2021

mgallien commented Jul 16, 2021

mgallien commented Jun 22, 2022

Tachi107 commented Jun 22, 2022

nextcloud-desktop-bot commented Jun 22, 2022

codecov bot commented Jun 22, 2022 • edited Loading

Codecov Report

mgallien Jul 4, 2023

Choose a reason for hiding this comment

mgallien left a comment

Choose a reason for hiding this comment

mgallien Jul 4, 2023

Choose a reason for hiding this comment

mgallien Jul 4, 2023

Choose a reason for hiding this comment

mgallien commented Feb 13, 2025

Tachi107 commented Feb 13, 2025 via email

thomasmerz commented Feb 14, 2025

Tachi107 commented Jul 3, 2021 •

edited

Loading

FlexW commented Jul 12, 2021 •

edited

Loading

codecov bot commented Jun 22, 2022 •

edited

Loading