Update config_sample_php_parameters.rst #11406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to documentation as config.php does not check `simpleSignUpLink.shown`, rather it checks `simpleSignUpLink` (with no sub property). Signed-off-by: Eric Schleicher <[email protected]>
|
Hi and thanks for your pull request 👍 This page is generated from https://github.com/nextcloud/server/blob/6d557569f6106f00867c970eeae2d8daa960e8be/config/config.sample.php#L2277C2-L2277C24 and therefore you need to change the sample file in nextcloud/server. However |
|
But alas `simpleSignUpLink.shown` is not used by the application and
doesn’t work.
I’ll go chase the right repo to resubmit, but making sure it’s clear that
the value in the sample config and the docs are ***incorrect*** (now
checking commit history)
…---------------------------------
CONFIDENTIALITY NOTICE: The contents of this email message and any
attachments are intended solely for the addressee(s) and may contain
confidential and/or privileged information and may be legally protected
from disclosure. If you are not the intended recipient of this message or
their agent, or if this message has been addressed to you in error, please
immediately alert the sender by reply email and then delete this message
and any attachments. If you are not the intended recipient, you are hereby
notified that any use, dissemination, copying, or storage of this message
or its attachments is strictly prohibited.
On Sat, Dec 23, 2023 at 2:05 PM Daniel ***@***.***> wrote:
Hi and thanks for your pull request 👍
This page is generated from
https://github.com/nextcloud/server/blob/6d557569f6106f00867c970eeae2d8daa960e8be/config/config.sample.php#L2277C2-L2277C24
and therefore you need to change the sample file in nextcloud/server.
However simpleSignUpLink.shown appears to be the right value.
—
Reply to this email directly, view it on GitHub
<#11406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7BBFYGKPWHBFPPBQNOUSTYK5ISLAVCNFSM6AAAAABA35Y5I6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGM3TOOBWGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to docs for config.php as the system does not check
simpleSignUpLink.shown, rather it checkssimpleSignUpLink(with no sub property) to control this functionality.☑️ Resolves
🖼️ Screenshots
N/A