Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming to primary & secondary #19

Open
MorrisJobke opened this issue Jan 18, 2019 · 6 comments
Open

Renaming to primary & secondary #19

MorrisJobke opened this issue Jan 18, 2019 · 6 comments

Comments

@MorrisJobke
Copy link
Member

master & slave are not the words we should us in our todays language. Sure it might me nitpicking, but we also should go forward with avoiding bad linguistic terms that sneaked into our everyday work. So I would aim to rename all the master to primary and the slave to secondary. I'm fine with keeping the existing configurations working, but we should let them not appear in most parts of the code as well as the documentation.

Or do you have other opinions/ideas on this one?

cc @schiessle @rullzer @nickvergessen @jancborchardt @shironextcloud @camilasan @blizzz @karlitschek

@camilasan
Copy link
Member

master & slave are not the words we should us in our todays language. Sure it might me nitpicking, but we also should go forward with avoiding bad linguistic terms that sneaked into our everyday work.

Totally agreed.

So I would aim to rename all the master to primary and the slave to secondary. I'm fine with keeping the existing configurations working, but we should let them not appear in most parts of the code as well as the documentation.

👍

@nickvergessen
Copy link
Member

https://en.m.wikipedia.org/wiki/Master/slave_(technology)#Terminology_concerns

Wikipedia explains it quite good. Also there is a suggestion which dates back to 2003 and asks to avoid those terms. I'm fine eitherway, as long as configuration continues to work.

@karlitschek
Copy link
Member

Let's rename it. But make sure that we touch all areas like documentation and website.

@jancborchardt
Copy link
Member

Good call! ❤

In the Wikipedia article @nickvergessen linked, the most used seems to be primary/replica. Should we go for that rather than primary/secondary? "replica" is also self-explanatory, while "secondary" is not.

@rullzer
Copy link
Member

rullzer commented Jan 22, 2019

@jancborchardt in this case it is not a replica which would be misleading.

Some background. In Primary mode the GSS handled incoming users and directs them to their node of destination. On this node the GSS is also installed but in secondary mode ready to receive the redirect send by the primary.

It is thus not a replica as if the primary system goes down the secondary system can't take over.

@jancborchardt
Copy link
Member

Thanks for the explanation! Then primary/secondary indeed makes most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants