Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote apptoken creation on oidc #173

Merged
merged 1 commit into from
Feb 25, 2025
Merged

remote apptoken creation on oidc #173

merged 1 commit into from
Feb 25, 2025

Conversation

ArtificialOwl
Copy link
Member

No description provided.

julien-nc
julien-nc approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm not sure I get when createAppToken is called.

@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Feb 25, 2025 •
edited
Loading

Looks good but I'm not sure I get when createAppToken is called.

From the master:

globalsiteselector/lib/Master.php

Line 309 in e95006a

protected function getAppToken($location, $uid, $password, $options) {

@ArtificialOwl ArtificialOwl merged commit 7259c47 into master Feb 25, 2025
20 checks passed
@ArtificialOwl ArtificialOwl deleted the fix-app-token-oidc branch February 25, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtificialOwl @julien-nc