Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting tests should include linting the rendered yaml from the helm templates #122

Open
1 task
tvories opened this issue Jul 2, 2021 · 1 comment
Open
1 task
Labels
enhancement New feature or request

Comments

@tvories
Copy link
Collaborator

tvories commented Jul 2, 2021

@kabakaev had a good suggestion about linting the rendered yaml during the testing actions.

  • The github actions should perform a lint test on the rendered helm templates.
@tvories tvories added the enhancement New feature or request label Jul 2, 2021
@jessebot
Copy link
Collaborator

At the time this was opened, this was our current linting and tests:
https://github.com/nextcloud/helm/blob/fddf924cb4fa3f0422bc1ed1073761b3b45f66d3/.github/workflows/lint-test.yaml

Now our linting ad tests look like this:
https://github.com/nextcloud/helm/blob/34fc2dfad665712bf379c84150f4b93cdbcea0f4/.github/workflows/lint-test.yaml

The chart now gets installed a few different ways (except for with redis enabled, which we need to do as per #604). The installation should actually catch any remaining linting issues. Is it safe to close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants