Impersonating deactivated user has unexpected behaviour

[RailsViceRoads]

Impersonating an deactivated user will switch to my self. Result is a "nested" impersonate of the user.

How to reproduce:

• select users menu and then select deactivated users
• impersonate a deactivated user

Expected behaviours:

• impersonate the selected user or
• an error message or
• no "impersonate"-possibility for this users (no entry in menu)

Actual behaviour:

• impersonate will "self-impersonate" the actual user
• logout will switch back from user to the same user

Versions

• NextCloud 13.0.4.0
• Impersonate App 1.0.4

[j-ed]

I can confirm the described behavior with Nextcloud 18.0.3 and the Impersonate app v1.8.0.

The best and easiest way to fix this problem is by removing the "Impersonate" menu entry for disabled users.

[gaitjan]

Same here with Nextcloud 27.0.0 and Impersonate app v1.14.0

[nursoda]

This feature would be especially useful for users/employees that have been disabled to refrain them from access. Yet, admins might need to export stuff like calendars for compliance reasons. This would be much easier using impersonate than to extract it directly from the database.

[piojan]

I would also suggest to disable the ability to impersonate disabled uses.
This is not working and causing unnecessary confusion.
As part of cleaning, yesterday I clicked impersonate on a disable user, haven't noticed that I still ended up as admin user, determined that the account is empty (cause admin account is also empty) and deleted it with data. Had to use the backup.
So I would suggest to close this issue by disabling the impersonation for disabled users and open a new issue to perhaps develop something in the future.