Photos 2.0 - Slow speeds, navigation, ordering issues #1195

valdearg · 2022-08-31T17:20:12Z

Describe the bug
Upgrading to the latest beta version 15.0.3 introduced the new version of Photos.

Currently I'm running into three different issues when viewing the overall apps/photos/ view which shows all images on the system.

Performance on my system is very slow to load. I suspect this may be because the initial dav query requests 1000 items. I'm using a separate PostgreSQL instance which contains a LOT of images and can be quite slow. If possible, the previous version requested a smaller number of images (I think it was around 15) which then performed another paginated search for a further number as you scrolled down the page. It would be amazing to get this part back, or perhaps customisable?
Ordering of images has changed, but I'm not entirely sure the exact ordering. Previously the view would display items in the most recently modified/recently added.

The DAV query seems to be working correctly. For example, the first items are:

<d:response>
        <d:href>/<redacted>/01_TD_1.jpg</d:href>
        <d:propstat>
            <d:prop>
                <oc:fileid>14270471</oc:fileid>
                <d:getlastmodified>Sat, 27 Aug 2022 13:40:59 GMT</d:getlastmodified>
                <d:getetag>&quot;c71bd8b70533133097c425313a719546&quot;</d:getetag>
                <d:getcontenttype>image/jpeg</d:getcontenttype>
                <d:getcontentlength>2110878</d:getcontentlength>
                <nc:has-preview>true</nc:has-preview>
                <nc:file-metadata-size>{&quot;width&quot;:1365,&quot;height&quot;:2048}</nc:file-metadata-size>
                <oc:favorite>0</oc:favorite>
                <d:resourcetype/>
            </d:prop>
            <d:status>HTTP/1.1 200 OK</d:status>
        </d:propstat>
        <d:propstat>
            <d:prop>
                <nc:realpath/>
                <nc:face-detections/>
            </d:prop>
            <d:status>HTTP/1.1 404 Not Found</d:status>
        </d:propstat>
    </d:response>
    <d:response>
        <d:href>/<redacted>//<redacted>/.jpg</d:href>
        <d:propstat>
            <d:prop>
                <oc:fileid>14270419</oc:fileid>
                <d:getlastmodified>Sat, 27 Aug 2022 13:40:46 GMT</d:getlastmodified>
                <d:getetag>&quot;76a3ca3a325df858b4cfacd6944b266d&quot;</d:getetag>
                <d:getcontenttype>image/jpeg</d:getcontenttype>
                <d:getcontentlength>1762165</d:getcontentlength>
                <nc:has-preview>true</nc:has-preview>
                <nc:file-metadata-size>{&quot;width&quot;:1306,&quot;height&quot;:1935}</nc:file-metadata-size>
                <oc:favorite>0</oc:favorite>
                <d:resourcetype/>
            </d:prop>
            <d:status>HTTP/1.1 200 OK</d:status>
        </d:propstat>
        <d:propstat>
            <d:prop>
                <nc:realpath/>
                <nc:face-detections/>
            </d:prop>
            <d:status>HTTP/1.1 404 Not Found</d:status>
        </d:propstat>
    </d:response>

However, in the photos view, we're getting these files first. Suggesting perhaps it's ordering the wrong way around maybe?

<d:response>
        <d:href>/<redacted>/Red_x5000-450x634.jpg</d:href>
        <d:propstat>
            <d:prop>
                <oc:fileid>14245079</oc:fileid>
                <d:getlastmodified>Fri, 26 Aug 2022 10:20:43 GMT</d:getlastmodified>
                <d:getetag>&quot;51ace037a58e2be631948ce5fb76e319&quot;</d:getetag>
                <d:getcontenttype>image/jpeg</d:getcontenttype>
                <d:getcontentlength>149554</d:getcontentlength>
                <nc:has-preview>true</nc:has-preview>
                <nc:file-metadata-size>{&quot;width&quot;:450,&quot;height&quot;:634}</nc:file-metadata-size>
                <oc:favorite>0</oc:favorite>
                <d:resourcetype/>
            </d:prop>
            <d:status>HTTP/1.1 200 OK</d:status>
        </d:propstat>
        <d:propstat>
            <d:prop>
                <nc:realpath/>
                <nc:face-detections/>
            </d:prop>
            <d:status>HTTP/1.1 404 Not Found</d:status>
        </d:propstat>
    </d:response>
    <d:response>
        <d:href>/<redacted>/Red_x5000-501x705.jpg</d:href>
        <d:propstat>
            <d:prop>
                <oc:fileid>14245080</oc:fileid>
                <d:getlastmodified>Fri, 26 Aug 2022 10:20:42 GMT</d:getlastmodified>
                <d:getetag>&quot;e3c1239146083d387ac22dd32cec6919&quot;</d:getetag>
                <d:getcontenttype>image/jpeg</d:getcontenttype>
                <d:getcontentlength>177274</d:getcontentlength>
                <nc:has-preview>true</nc:has-preview>
                <nc:file-metadata-size>{&quot;width&quot;:501,&quot;height&quot;:705}</nc:file-metadata-size>
                <oc:favorite>0</oc:favorite>
                <d:resourcetype/>
            </d:prop>
            <d:status>HTTP/1.1 200 OK</d:status>
        </d:propstat>
        <d:propstat>
            <d:prop>
                <nc:realpath/>
                <nc:face-detections/>
            </d:prop>
            <d:status>HTTP/1.1 404 Not Found</d:status>
        </d:propstat>
    </d:response>

I suspect this final issue will be difficult to replicate and could be due to the speed issues previously and it would be great to get some further users testing this. If you scroll down the Photos page, say after 50/100 images and view an image, if you click off the image (so outside the image on the right or left), sometimes this reverts to the top of the page. It's intermittent for me but does seem to happen after I've done this a few times.

It's a bit difficult to send screenshots I'm afraid as it's a lot of family pictures currently at the top. For the moment I've reverted to the previous beta release due to the performance.

meichthys · 2022-08-31T18:11:28Z

What method did you use to install the 2.0 version?

valdearg · 2022-08-31T18:15:45Z

This was included in the latest beta of version 15 according to the release notes: nextcloud/server#33674

I noticed a fairly significant change to the UI, though I think the version number may have appeared as the same in the apps view. May just be because it's beta.

meichthys · 2022-08-31T18:27:19Z

So you also running the nextcloud server beta?

valdearg · 2022-08-31T18:29:11Z

Yes, beta 2 currently.

marcelklehr · 2022-08-31T18:50:38Z

cc @artonge

artonge · 2022-09-06T10:08:37Z

N°1 addressed in #1209

valdearg · 2022-09-18T13:33:17Z

3 can be ignored, I think this was an issue with the theme I was using.

Updated to the latest beta 6 and the performance does seem to be much better.

So just the ordering of images now!

valdearg · 2022-10-11T16:47:46Z

Any updates on the ordering issues @artonge? Just aware that it was touted as a big feature upgrade and it's a bit unusable when you have a good number of images.

artonge · 2022-10-11T17:03:32Z

Any updates on the ordering issues @artonge? Just aware that it was touted as a big feature upgrade and it's a bit unusable when you have a good number of images.

In the forum, I pointed @andyxheli to a possible starting point to investigate the issue.

Here it is again:

I can't find sortFilesByTimestamp anymore. Either it does not exist, and the .sort is not using it. Or it exists but the logic is wrong.

photos/src/mixins/FilesByMonthMixin.js

Line 40 in c8bf3a5

.forEach(month => filesByMonth[month].sort(this.sortFilesByTimestamp))

@valdearg Any chances you could open a PR for that ?

valdearg · 2022-10-11T18:36:22Z

Hrm, does this help at all? I'm afraid I'm not an expert:

photos/src/components/FilesPicker.vue

Line 166 in 05d89c6

sortFilesByTimestamp(fileId1, fileId2) {

It looks like that used to be included in the FilesPicker.vue, but no longer.

valdearg · 2022-10-11T18:47:34Z

#1330 maybe, good luck.

ghost · 2022-10-11T19:05:10Z

sorry @artonge bit a little busy. didnt mean to ignore you.

ghost · 2022-10-11T19:05:43Z

@valdearg did you try to manually apply this patch ? did it help ?

valdearg · 2022-10-11T19:14:52Z

@valdearg did you try to manually apply this patch ? did it help ?

Have to confess, I've never setup a NextCloud development process, I get an error about versions of Photos so probably need to do something else: "The files of the app Photos (photos) were not replaced correctly. Make sure it is a version compatible with the server."

Main website is on beta2 so doubt it's a drop in replacement!

If anyone is able to test it, that'd be great!

ghost · 2022-10-11T19:18:49Z

I can test. Can you give me a scenario to try before and after the test please

artonge · 2022-10-11T19:19:11Z

"The files of the app Photos (photos) were not replaced correctly. Make sure it is a version compatible with the server."

Both 'photos' and 'server' needs to be on the same branch, either master or stable25, else you will have this king of error :)

valdearg · 2022-10-11T19:33:37Z

I can test. Can you give me a scenario to try before and after the test please

Thanks! Simple test is that the images should be in the order they were added to the system, so if you add a new image to a folder NOW, it should show at the top. All images should then be in the order they were added.

ghost · 2022-10-11T19:42:58Z

@artonge Hmm so question i though i can just modify the file but i cant so do i have to bulid a test app and then install it on the server ? if so, how do i go about doing that ? unless @valdearg you already have the app complied and ready for install ?

artonge · 2022-10-11T19:45:19Z

If you want to test on a live server, you could compile on your dev machine and move the build files to the server.
You could also install the build tools on the server and compile on it directly, but that might be difficult or unwanted.

ghost · 2022-10-11T19:53:35Z

I only have a test server my windows machine only run github desktop or on my linux "ubuntu' then i have my test VM running Nc 25 RC3

valdearg · 2022-10-11T20:11:47Z

Haha, I have a broken app so far I'm afraid! It just redirects to the Files currently.

ghost · 2022-10-11T20:15:35Z

Haha oh boy. I'm working on creating a dev setup

szaimen · 2022-10-11T20:28:59Z

@valdearg @andyxheli if you have docker installed locally, you can check the PR out and test it easily with:

docker run -it \
--name nextcloud-easy-test \
-p 127.0.0.1:8443:443 \
-e PHOTOS_BRANCH=valdearg:patch-2 \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
ghcr.io/szaimen/nextcloud-easy-test:latest

ghost · 2022-10-11T20:30:50Z

@szaimen Thank you! I'll give that a try :)

ghost · 2022-10-11T20:42:58Z

I get an error as soon as i click on photos app see admin @valdearg how about you ?

szaimen · 2022-10-11T20:44:15Z

Ah, that is probably my fault because the viewer app is missing.

Please try this one:

docker run -it \
--name nextcloud-easy-test \
-p 127.0.0.1:8443:443 \
-e PHOTOS_BRANCH=valdearg:patch-2 \
-e VIEWER_BRANCH=master \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
ghcr.io/szaimen/nextcloud-easy-test:latest

ghost · 2022-10-11T20:45:42Z

No worries. Trying it again, Thank you!

ghost · 2022-10-11T20:57:32Z

Looks good to me :)

valdearg · 2022-10-11T21:12:39Z

OK, from my testing, thanks to the fantastic help from @szaimen there, I can also confirm it seems to be working too.

Just testing some other oddities as well.

valdearg · 2022-10-11T21:16:35Z

OK, think that's all set! That patch seems to resolve it, thanks for everyone's help with this!

Not sure the procedure for fully approving the fix and including it in where it needs to be fully, but it should be good.

szaimen · 2022-10-12T09:45:40Z

All done now? :)

artonge · 2022-10-12T11:50:14Z

Let's close this one, feel free to open another more specific issue if needed :)

valdearg added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Aug 31, 2022

artonge closed this as completed Oct 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Photos 2.0 - Slow speeds, navigation, ordering issues #1195

Photos 2.0 - Slow speeds, navigation, ordering issues #1195

valdearg commented Aug 31, 2022

meichthys commented Aug 31, 2022

valdearg commented Aug 31, 2022

meichthys commented Aug 31, 2022

valdearg commented Aug 31, 2022

marcelklehr commented Aug 31, 2022

artonge commented Sep 6, 2022

valdearg commented Sep 18, 2022

valdearg commented Oct 11, 2022

artonge commented Oct 11, 2022 •

edited

Loading

valdearg commented Oct 11, 2022

valdearg commented Oct 11, 2022

ghost commented Oct 11, 2022

ghost commented Oct 11, 2022

valdearg commented Oct 11, 2022

ghost commented Oct 11, 2022

artonge commented Oct 11, 2022

valdearg commented Oct 11, 2022

ghost commented Oct 11, 2022

artonge commented Oct 11, 2022

ghost commented Oct 11, 2022

valdearg commented Oct 11, 2022

ghost commented Oct 11, 2022

szaimen commented Oct 11, 2022

ghost commented Oct 11, 2022

ghost commented Oct 11, 2022

szaimen commented Oct 11, 2022

ghost commented Oct 11, 2022

ghost commented Oct 11, 2022

valdearg commented Oct 11, 2022

valdearg commented Oct 11, 2022

szaimen commented Oct 12, 2022

artonge commented Oct 12, 2022

Photos 2.0 - Slow speeds, navigation, ordering issues #1195

Photos 2.0 - Slow speeds, navigation, ordering issues #1195

Comments

valdearg commented Aug 31, 2022

meichthys commented Aug 31, 2022

valdearg commented Aug 31, 2022

meichthys commented Aug 31, 2022

valdearg commented Aug 31, 2022

marcelklehr commented Aug 31, 2022

artonge commented Sep 6, 2022

valdearg commented Sep 18, 2022

valdearg commented Oct 11, 2022

artonge commented Oct 11, 2022 • edited Loading

valdearg commented Oct 11, 2022

valdearg commented Oct 11, 2022

ghost commented Oct 11, 2022

ghost commented Oct 11, 2022

valdearg commented Oct 11, 2022

ghost commented Oct 11, 2022

artonge commented Oct 11, 2022

valdearg commented Oct 11, 2022

ghost commented Oct 11, 2022

artonge commented Oct 11, 2022

ghost commented Oct 11, 2022

valdearg commented Oct 11, 2022

ghost commented Oct 11, 2022

szaimen commented Oct 11, 2022

ghost commented Oct 11, 2022

ghost commented Oct 11, 2022

szaimen commented Oct 11, 2022

ghost commented Oct 11, 2022

ghost commented Oct 11, 2022

valdearg commented Oct 11, 2022

valdearg commented Oct 11, 2022

szaimen commented Oct 12, 2022

artonge commented Oct 12, 2022

artonge commented Oct 11, 2022 •

edited

Loading