Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

richdocuments effectively disables ability to open files with Collabora if onlyoffice app is installed #3456

Open
gchatthes opened this issue Feb 3, 2024 · 3 comments

Comments

@gchatthes
Copy link

gchatthes commented Feb 3, 2024

Describe the bug
If richdocuments detects onlyoffice app, it completely disables handling of any documents which are also compatible with onlyoffice. This shouldn't be the correct approach, since it effectively allows only a few extensions to be handled by richdocuments and the user has no way of opening file with those disabled extension with Collabora.
Furtermore, onlyoffice allows to open any documents from the context menu so the correct approach would be to have richdocuments handle all office documents by default and if user want's to open a document with onlyoffice, he can do so by opening the context menu and selecting the option to open onlyoffice.
The code which handles this is in file:
./lib/Service/CapabilitiesService.php
Deleting/commenting out this section fixes the issue

		if ($this->appManager->isEnabledForUser('onlyoffice')) {
			return true;
		}

To Reproduce
Steps to reproduce the behavior:

  1. install onlyoffice app (no need to configure it)
  2. Click on any document which is supported by onlyoffice (docx, xlsx etc.)
  3. Documents either open with onlyoffice (if correctly configured), or a download dialog appears

Expected behavior
If the document is supported by richdocuments it should open Collabora. If user wants to open it with onlyoffice, he can do so by selecting the appropriate option in the context menu.

Client details:

  • OS: Debian 12 - Bookworm
  • Browser: any
  • Version: any
  • Device: desktop

Server details

Operating system: Debian 12 Bookworm / Docker install (latest)

**Web server: Apache/2.4.57 (Debian) / within docker

**Database: Mariadb, docker image version latest (11.2.2)

**PHP version: php 8.2.15

**Nextcloud version: 8.0.2

**Version of the richdocuments app: 8.3.1

**Version of Collabora Online: 23.05.8.4

@gchatthes gchatthes changed the title richdocuments effectively disable Collabora if onlyoffice plugin is installed richdocuments effectively disables ability to open files with Collabora if onlyoffice plugin is installed Feb 3, 2024
@gchatthes gchatthes changed the title richdocuments effectively disables ability to open files with Collabora if onlyoffice plugin is installed richdocuments effectively disables ability to open files with Collabora if onlyoffice app is installed Feb 3, 2024
@chunsiyang
Copy link

same here with the following environment
nextcloud 28.0.3
nextcloud office 8.3.2
Collabora server 23.05.9.3 11d108b
onlyoffice 9.0.0

@thebearon
Copy link
Collaborator

This is since #2301, made for #2281.

@unnilennium
Copy link

unnilennium commented Apr 9, 2024

confirm the behaviour which is new after upgrade from 26 to 28.0.4
One could prefer onlyoffice for some use case and keep richdocument for all other documents !

could we just exclude document type explicitly selected in onlyoffice configuration, letting also option to "open with collabora using contextual menu"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants