Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF export includes reviewed state #3680

Closed
jospoortvliet opened this issue May 8, 2024 · 9 comments
Closed

PDF export includes reviewed state #3680

jospoortvliet opened this issue May 8, 2024 · 9 comments

Comments

@jospoortvliet
Copy link
Member

This is in between a bug report and a bug report - from a technical pov I'm sure it's a feature request, but from an user pov it's more like a bug. The issue:

When using the export to PDF, the resulting PDF includes the changes - not exactly what you'd expect, as PDF is typically an end product... here's how it works RN:

Screenshot 2024-05-08 at 14 07 32
Screenshot 2024-05-08 at 14 07 50
Screenshot 2024-05-08 at 14 09 22
Screenshot 2024-05-08 at 14 09 35
Screenshot 2024-05-08 at 14 10 26

What I'd hope for is an option perhaps "show changes" that is off by default ;-)

@juliusknorr
Copy link
Member

Maybe @pedropintosilva has any insights if such an option is available or could be exposed from core ?

@jospoortvliet
Copy link
Member Author

Hi @pedropintosilva do you have any input?

@pedropintosilva
Copy link
Contributor

pedropintosilva commented May 21, 2024

@jospoortvliet yes and sorry for not updating this. I think I mentioned this in some call but I forgot to update this.


In Short: Thanks! I think this would be quite valuable. To allow users to export files be that PDF or other file type with or without tracking changes displayed (similar as it's already possible when editing the document via Review > Show toggle button)


We are still not working on this. It might be useful to implement a solution that is not PDF dependent (changing the PDF dialog etc) because well, it would only work for that and because adding one more option within that dialog would just increase the number of options and the probability of user never see it. Thus, maybe adding a subtle intermediary via snackbar that allows the user to understand what is going on and with a button to switch off.

But then again it would be quite annoying to have this appearing every time... So, it needs thinking here

@pedropintosilva
Copy link
Contributor

right now I think we have the same behaviour as other office suites which is export what is visible to the user. So, if the user toggles that off in the tabbed the PDF export should come out without changes

@pedropintosilva
Copy link
Contributor

pedropintosilva commented May 21, 2024

[...] So, if the user toggles that off in the tabbed the PDF export should come out without changes

@jospoortvliet if this doesn't suffice then I wonder if having another button something along the lines of "Publish" something that would signify "Export without tracking changes" that would hide the tracking changes + trigger the PDF export dialog wouldn't be better.

@jospoortvliet
Copy link
Member Author

Hmmm, I see. Looking at the dialog, a generic solution would indeed be to have an option in the list of "export X" things that says "export tracking changes", which probably should be off by default for PDF's. So at least you're not losing anything but do the sane thing by default.

@pedropintosilva
Copy link
Contributor

@jospoortvlietI think I understand what you mean. We would have some troubles with lengthy labels etc but probably it could be worked out. But just to be sure this is what you mean, right?

image

(in there ^ I removed the as in the Export as button as it then allow us to have the shortened label inside With)

Nevertheless, I'm still not sure if changing the default behaviour is the right move. But if the above is what you mean then we can maybe test the waters and get feedback via the community/development edition. What do you think?

@jancborchardt
Copy link
Member

jancborchardt commented Jun 25, 2024

The "Show" button in the "Review" tab toggles the state already – when you export as PDF, it will show whatever you see.

So when you want to export without the change details visible, you just toggle that option and then export. Seems fine to me @jospoortvliet? Any additional option in the already very complicated export dialog will just overcomplicate it more. :\

@jospoortvliet
Copy link
Member Author

You're right of course, you can just turn it off in the view. Maybe I'm overcomplicating it and that is the easiest solution.

Ok, let's focus on bigger things ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants