From 301a7dacf19d9888dbce3495fd80b755732f40ee Mon Sep 17 00:00:00 2001 From: "Grigorii K. Shartsev" Date: Fri, 6 Sep 2024 16:47:08 +0200 Subject: [PATCH 1/6] fix(files_sharing): checkbox for password in link share is not shown Signed-off-by: Grigorii K. Shartsev --- apps/files_sharing/src/components/SharingEntryLink.vue | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/files_sharing/src/components/SharingEntryLink.vue b/apps/files_sharing/src/components/SharingEntryLink.vue index 294f48b5350e2..f62a0358072a0 100644 --- a/apps/files_sharing/src/components/SharingEntryLink.vue +++ b/apps/files_sharing/src/components/SharingEntryLink.vue @@ -198,6 +198,7 @@ import { Type as ShareTypes } from '@nextcloud/sharing' import Vue from 'vue' import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton.js' +import NcActionCheckbox from '@nextcloud/vue/dist/Components/NcActionCheckbox.js' import NcActionInput from '@nextcloud/vue/dist/Components/NcActionInput.js' import NcActionLink from '@nextcloud/vue/dist/Components/NcActionLink.js' import NcActionText from '@nextcloud/vue/dist/Components/NcActionText.js' @@ -223,6 +224,7 @@ export default { ExternalShareAction, NcActions, NcActionButton, + NcActionCheckbox, NcActionInput, NcActionLink, NcActionText, From b96661bd585534126082c97a0d318a1f647abc74 Mon Sep 17 00:00:00 2001 From: "Grigorii K. Shartsev" Date: Fri, 6 Sep 2024 16:48:05 +0200 Subject: [PATCH 2/6] fix(files_sharing): add accessible labels in link share creation Signed-off-by: Grigorii K. Shartsev --- .../src/components/SharingEntryLink.vue | 27 +++++++++---------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/apps/files_sharing/src/components/SharingEntryLink.vue b/apps/files_sharing/src/components/SharingEntryLink.vue index f62a0358072a0..cda056a4dca34 100644 --- a/apps/files_sharing/src/components/SharingEntryLink.vue +++ b/apps/files_sharing/src/components/SharingEntryLink.vue @@ -65,27 +65,26 @@ - - {{ t('files_sharing', 'Password protection (enforced)') }} - - - - {{ t('files_sharing', 'Expiration date (enforced)') }} - @@ -207,6 +204,7 @@ import NcActions from '@nextcloud/vue/dist/Components/NcActions.js' import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar.js' import Tune from 'vue-material-design-icons/Tune.vue' +import IconCalendarBlank from 'vue-material-design-icons/CalendarBlank.vue' import SharingEntryQuickShareSelect from './SharingEntryQuickShareSelect.vue' @@ -231,6 +229,7 @@ export default { NcActionSeparator, NcAvatar, Tune, + IconCalendarBlank, SharingEntryQuickShareSelect, }, From e43aa76a0036dbdc04ca54d2cab4ec2c5f33bde3 Mon Sep 17 00:00:00 2001 From: fenn-cs Date: Wed, 6 Nov 2024 16:50:59 +0100 Subject: [PATCH 3/6] fix(SharingEntryLink): Show default password before create if any Prevent silent addition of expiration date to shares. Prevent silent addition for password to shares. Both now have a `shareRequiresReview` check Resolves : https://github.com/nextcloud/server/issues/48860 Signed-off-by: fenn-cs --- apps/files_sharing/src/components/SharingEntryLink.vue | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/files_sharing/src/components/SharingEntryLink.vue b/apps/files_sharing/src/components/SharingEntryLink.vue index cda056a4dca34..f6e162b7d87a8 100644 --- a/apps/files_sharing/src/components/SharingEntryLink.vue +++ b/apps/files_sharing/src/components/SharingEntryLink.vue @@ -96,9 +96,9 @@ - -