ci: fail psalm when baseline update required

Signed-off-by: Daniel Kesselberg <[email protected]>
nextcloud · Sep 30, 2024 · 7286b35 · 7286b35
1 parent 39a708b
commit 7286b35
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/static-code-analysis.yml b/.github/workflows/static-code-analysis.yml
@@ -36,7 +36,7 @@ jobs:
 
       - name: Show potential changes in Psalm baseline
         if: always()
-        run: git diff -- . ':!lib/composer'
+        run: git diff --exit-code -- . ':!lib/composer'
 
       - name: Upload Analysis results to GitHub
         if: always()
@@ -98,4 +98,4 @@ jobs:
 
       - name: Show potential changes in Psalm baseline
         if: always()
-        run: git diff -- . ':!lib/composer'
+        run: git diff --exit-code -- . ':!lib/composer'
diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml
@@ -109,7 +109,6 @@
   <file src="apps/dav/lib/CalDAV/CalDavBackend.php">
     <InvalidNullableReturnType>
       <code>array</code>
-      <code>array</code>
     </InvalidNullableReturnType>
     <LessSpecificReturnStatement>
       <code>Reader::read($objectData)</code>
@@ -1423,7 +1422,6 @@
   </file>
   <file src="core/routes.php">
     <InvalidScope>
-      <code>$this</code>
       <code>$this</code>
       <code><![CDATA[$this->create('core_ajax_update', '/core/ajax/update.php')]]></code>
     </InvalidScope>
@@ -2103,7 +2101,6 @@
     <MoreSpecificReturnType>
       <code>\OC\Files\Node\Node</code>
       <code>\OC\Files\Node\Node[]</code>
-      <code>\OC\Files\Node\Node[]</code>
     </MoreSpecificReturnType>
   </file>
   <file src="lib/private/Files/Node/HookConnector.php">