Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use the new user modal to edit users #40903

Open
Ornanovitch opened this issue Oct 13, 2023 · 4 comments
Open

Re-use the new user modal to edit users #40903

Ornanovitch opened this issue Oct 13, 2023 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: users and groups

Comments

@Ornanovitch
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
I'm always surprised how inconvenient user editing is: editing directly in the user's row is not very intuitive, and give the feeling of being tight. In addition, it seems to be a perpetual source of little problems to be fixed for devs (see for e.g #40902)

Describe the solution you'd like
A real form! There is already a super simple and accessible form when creating a new user, why not simply reusing it? :)

Describe alternatives you've considered
TINA 🐙

Additional context
Way to heaven:

Screenshot 2023-10-13 at 13-32-57 Utilisateurs actifs - Utilisateurs - Utilisateurs - Brume

@Ornanovitch Ornanovitch added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Oct 13, 2023
@Ornanovitch
Copy link
Contributor Author

Ornanovitch commented Nov 17, 2023

Any thoughts on this @JuliaKirschenheuter as you worked on this recently?

@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv added the needs review Needs review to determine if still applicable label Sep 17, 2024
@marcoambrosini
Copy link
Member

Agree that we should remove inline editing and just have an edit button on the row that opens a dialog with a form

@Ornanovitch
Copy link
Contributor Author

Ornanovitch commented Sep 17, 2024

A compromise An enhancement could be to have both:

  • modal editing for usual edit (to edit one user at a time)
  • inline editing for some kind of "bulk edit": you select rows, you click on an Edit button to edit all selected rows inline, and then you click on a Validate button (a unique button for all modifications)

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs review Needs review to determine if still applicable labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: users and groups
Projects
None yet
Development

No branches or pull requests

4 participants