Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Move AppStore/Fetcher/Fetcher.php timeout to config.php #40947

Closed
bernd-wechner opened this issue Oct 17, 2023 · 3 comments
Closed
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement

Comments

@bernd-wechner
Copy link

This is related to: #16972

In lib/private/App/AppStore/Fetcher/Fetcher.php there is a timeout setting.

This should be a configuration available in config.php, to make it a) discoverable and b) tuneable. and c) not require an edit to site source.

On a fresh install in Tasmania, I found no app store. And no clue why. I had to drill into logs and then google to find the issue above. I upped the timeout and I have an app store. It is mentioned in the issue that: "If a job need specific longer time it should set that." in which the author of the PR is tacitly agreeing (admitting) that this may need site specific tuning. Further to which numerous punters on that PR report as do I that larger timeouts are needed in their context.

I will add to this request that if the timeout is exceeded a sensible message appears on the App store to convey that and a link to suggest how to tune it.

@bernd-wechner bernd-wechner added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Oct 17, 2023
@joshtrichards
Copy link
Member

Hi @bernd-wechner - Thanks for your report. This is a duplicate of #40082 so let's consolidate tracking of this enhancement idea there. Feel free to subscribe to that issue and/or upvote it for prioritization and/or add your comments to the discussion.

@joshtrichards joshtrichards closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2023
@bernd-wechner
Copy link
Author

bernd-wechner commented Oct 17, 2023

Thanks for that. I did some thorough searches first and failed to find that one alas. My apologies.

I am behind though as I did search: timeout app store. And that cheeky is in the title. Scratching my head as to why I didn't find it.

@joshtrichards
Copy link
Member

I changed the title of that one after I saw your report come in. So no apology necessary.. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement
Projects
None yet
Development

No branches or pull requests

2 participants