Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Adjust table header to look like on previous versions #41710

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix(files): Adjust table header to look like on previous versions #41710

merged 2 commits into from
Nov 27, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 23, 2023 •
edited
Loading

Summary

Adjust the files table header to look like on previous versions by changing the text color.
This now aligns with the table header example from the vue components were we already had a design review by @jancborchardt .

Screenshots

before after
Screen Shot 2023-11-24 at 00 26 43 Screen Shot 2023-11-24 at 00 23 49
Screen Shot 2023-11-24 at 00 24 37 Screen Shot 2023-11-24 at 00 24 08

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Nov 23, 2023
@susnux susnux self-assigned this Nov 23, 2023
@susnux
Copy link
Contributor Author

susnux commented Nov 23, 2023

/backport to stable28

@AndyScherzinger
Copy link
Member

@JuliaKirschenheuter @susnux is this accessible contrast-wise?

@susnux
Copy link
Contributor Author

susnux commented Nov 24, 2023

is this accessible contrast-wise?

Yes it is maxcontrast on main background and maxcontrast on background-hover. Both combinations are tests by our CI for accessibility.

artonge
artonge approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is still accessible :)

@susnux
Copy link
Contributor Author

susnux commented Nov 27, 2023

@jancborchardt @nimishavijay I think this is mainly a design issue, so I would like to wait for your opinion on this.

@susnux susnux requested a review from nimishavijay November 27, 2023 14:30
nimishavijay
nimishavijay approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good! :)

@susnux susnux force-pushed the fix/files-table-header branch from 7860a51 to 7809364 Compare November 27, 2023 16:09
@susnux susnux merged commit c13b748 into master Nov 27, 2023
40 of 41 checks passed
@susnux susnux deleted the fix/files-table-header branch November 27, 2023 16:31
@susnux susnux mentioned this pull request Dec 2, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay approved these changes

@artonge artonge artonge approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@Pytal Pytal Awaiting requested review from Pytal

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@susnux susnux

Labels
3. to review Waiting for reviews backport-request design Design, UI, UX, etc. feature: files regression
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Too much focus on the file list headings
4 participants
@susnux @AndyScherzinger @artonge @nimishavijay