Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Absence event starts one day too early and is always set to UTC #42139

Closed
4 of 8 tasks
ChristophWurst opened this issue Dec 11, 2023 · 5 comments · Fixed by #42142
Closed
4 of 8 tasks

[Bug]: Absence event starts one day too early and is always set to UTC #42139

ChristophWurst opened this issue Dec 11, 2023 · 5 comments · Fixed by #42142
Assignees
Labels

Comments

@ChristophWurst
Copy link
Member

⚠️ This issue respects the following points: ⚠️

Bug description

Despite #41703, setting an out of office with 28 RC3 leads to a calendar event that starts one day too early and is drifting for timezones with an offset due to the event being set to UTC.

Steps to reproduce

  1. Log into Nextcloud
  2. Configure an absence
  3. Open Calendar

Expected behavior

Absence events starts 00:00 of my first day of absence and ends 00:00 of the first day I'm back.

Installation method

None

Nextcloud Server version

28

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@ChristophWurst ChristophWurst added bug 1. to develop Accepted and waiting to be taken care of feature: dav regression feature: caldav Related to CalDAV internals labels Dec 11, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone Dec 11, 2023
@ChristophWurst ChristophWurst self-assigned this Dec 11, 2023
@ChristophWurst ChristophWurst moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Dec 11, 2023
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Dec 11, 2023
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Dec 11, 2023

Debugging

  • Login timezone: browser sends correct timezone during login ✔️
  • Actual value in database: Europe/Vienna ✔️
  • Time during absence configuration: correct, not a day early. ✔️
  • Calendar timezone in oc_calendars: NULL ⚠️

@ChristophWurst
Copy link
Member Author

The day drift is fixable easily.

The time drift only happens if the calendar has no timezone set. Other code uses better sources for the timezone anyway, so we should migrate this too. The problem created is that we will only have the timezone id, not the full VTIMEZONE component.

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 11, 2023
@ChristophWurst
Copy link
Member Author

PR at #42142

@ChristophWurst
Copy link
Member Author

This bug should only affect the ooo event, not the status or the autoresponder.

@ChristophWurst
Copy link
Member Author

In alignment with @AndyScherzinger we target release 28.0.1 for the backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants