Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): Adjust status colors and make dark theme fully accessible #42287

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 14, 2023

Summary

This is based on #42285 which provides initial support for WCAG contrast calculation and unit testing the themes.

This fixes two problem:

  1. The status colors are still not fully accessible especially on blurry background
  2. The dark theme is not fully accessible on all supported color + background combinations

besides fixing the issues this also adds a unit test for the dark theme to get notified in case of errors.

For the dark theme all status colors needed to a bit more brighter:

dark-theme-colors

For the default theme warning and error needed to be adjusted:

error warning
error warning

Checklist

@susnux susnux force-pushed the fix/theming-color-utils-primary branch from 9691b35 to 3441852 Compare December 15, 2023 15:15
@emoral435 emoral435 force-pushed the fix/theming-color-utils-primary branch from 3441852 to aededaf Compare December 15, 2023 18:14
@susnux susnux force-pushed the fix/theming-color-utils-primary branch from aededaf to 84123b3 Compare December 15, 2023 20:09
Base automatically changed from fix/theming-color-utils-primary to master December 15, 2023 20:35
@susnux susnux force-pushed the fix/dark-theme-and-element-colors branch from cd416d4 to ee63ecd Compare December 15, 2023 21:17
@susnux susnux requested a review from emoral435 December 15, 2023 21:18
@susnux
Copy link
Contributor Author

susnux commented Dec 15, 2023

/backport to stable28

@susnux susnux force-pushed the fix/dark-theme-and-element-colors branch 2 times, most recently from 734f0dc to 8dee78f Compare December 16, 2023 13:49
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 great work! Tested on several places, all good until now

@emoral435 emoral435 force-pushed the fix/dark-theme-and-element-colors branch from 8dee78f to ae12a73 Compare December 18, 2023 16:25
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well :)

@emoral435 emoral435 merged commit 8f1acd1 into master Dec 18, 2023
50 checks passed
@emoral435 emoral435 deleted the fix/dark-theme-and-element-colors branch December 18, 2023 17:13
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@susnux
Copy link
Contributor Author

susnux commented Dec 18, 2023

/backport to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ShGKme
Copy link
Contributor

ShGKme commented Nov 2, 2024

Warning is not contrast with text

image

@susnux
Copy link
Contributor Author

susnux commented Nov 2, 2024

Warning is not contrast with text

Known limitation of dark theme but warning background with text is also deprecated and shall not be used by design team.
So we can fix this on components, but it simply should only be used for graphical elements and text should be color warning text on default background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants