Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userstatus): set user status to 'In a meeting' if calendar is busy #42309

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Dec 15, 2023

Summary

A calendar query looks at the calendar to see if there are any events. TRANSPARENT calendars are ignored.

We ignore events if they're

  • an OOO calendar event as that status is already handled
  • a TRANSPARENT event
  • an event that started before the user has set a custom status

We also do not overwrite a "DND" or "INVISIBLE" status or the Talk "In a Call" message.

How to test

  • For OOO: set an OOO period and see that the OOO status stays persistent and is not overwritten by the calendar automation
  • For calendar events: set an event in your calendar. Wait until it begins and wait until after it ends, status should be set to "In a meeting" and reset after. I use 5 / 10 minute events to test.
  • For transparent calendar events - the same, see that the staus DOES NOT change to "In a meeting"
  • For all day events, the status should stay "In a meeting" at all times unless overwritten by a custom status and should not revert back
  • Overwriting with a custom status: See "In a meeting" status, set a custom status, reload. See that custom status still exists until next event.

Checklist

@skjnldsv skjnldsv mentioned this pull request Dec 15, 2023
4 tasks
@miaulalala
Copy link
Contributor Author

/backport to stable28

@miaulalala
Copy link
Contributor Author

Documentation: nextcloud/documentation#11405

@skjnldsv
Copy link
Member

Please get this in asap if needed for 28.0.1

@miaulalala miaulalala force-pushed the enh/meeting-status-automation branch 2 times, most recently from 6c3411e to 0198da4 Compare December 19, 2023 12:36
@miaulalala miaulalala force-pushed the enh/meeting-status-automation branch from 0198da4 to 4c6eff9 Compare December 19, 2023 13:59
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Dec 19, 2023
@miaulalala miaulalala merged commit 94a5e6c into master Dec 19, 2023
50 checks passed
@miaulalala miaulalala deleted the enh/meeting-status-automation branch December 19, 2023 15:40
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: status
Projects
Development

Successfully merging this pull request may close these issues.

Set user status to busy when own calendar contains busy event
4 participants