Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't query oc_properties for metadata props #42350

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Dec 18, 2023

This prevents a SQL request on oc_properies on each requested files.

Part of #42346

@artonge artonge self-assigned this Dec 18, 2023
@artonge
Copy link
Contributor Author

artonge commented Dec 18, 2023

/backport to stable28

@artonge artonge changed the title Don't query custom properties for metadata props Don't query oc_properties for metadata props Dec 18, 2023
@artonge artonge force-pushed the artonge/perf/dont_query_custom_properties_for_metadata_dav_props branch from 7d519ef to 6aa2d2d Compare December 18, 2023 12:09
@artonge artonge enabled auto-merge December 18, 2023 13:24
@artonge artonge added this to the Nextcloud 29 milestone Dec 18, 2023
@artonge artonge added the 3. to review Waiting for reviews label Dec 18, 2023
@artonge artonge merged commit 455a6d1 into master Dec 18, 2023
50 checks passed
@artonge artonge deleted the artonge/perf/dont_query_custom_properties_for_metadata_dav_props branch December 18, 2023 15:13
@solracsf
Copy link
Member

@artonge any objection backporting to 27?

@artonge
Copy link
Contributor Author

artonge commented Dec 19, 2023

It would need to be adapted as the metadata API was not exactly the same

@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants