Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: Replace link with NcButton #42596

Closed
JuliaKirschenheuter opened this issue Jan 5, 2024 · 4 comments · Fixed by #42636 or #42986
Closed

[BITV]: Replace link with NcButton #42596

JuliaKirschenheuter opened this issue Jan 5, 2024 · 4 comments · Fixed by #42636 or #42986
Assignees
Labels
1. to develop Accepted and waiting to be taken care of accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Jan 5, 2024

Contrast issue, html valid elements issue, <img alt=""> issue

index.php/u/admin:

Screenshot from 2024-01-05 13-39-23

@szaimen
Copy link
Contributor

szaimen commented Jan 18, 2024

Seems to work in general, but this button looks a bit weird when it is selected via keyboard:
image

Also hover in dark-mode is broken:
image

@szaimen szaimen reopened this Jan 18, 2024
@emoral435
Copy link
Contributor

emoral435 commented Jan 19, 2024

@szaimen That's interesting, I am trying this out on my own local instance, but it looks all fine to me 😕 Can you provide a picture of the settings that you use that give you this weird look to the button?

Heres a gif of me checking it out :
firefox_YpOAKKGQeN

@susnux
Copy link
Contributor

susnux commented Jan 20, 2024

@szaimen could it be that you are testing stable28? In this case we probably need to backport #42668 ?

@szaimen
Copy link
Contributor

szaimen commented Jan 20, 2024

@szaimen could it be that you are testing stable28? In this case we probably need to backport #42668 ?

Yes, always testing with stable28 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of accessibility
Projects
None yet
4 participants