Notifications menu and contact-search menu broken with certain predefined backgrounds

[nickvergessen]

How to use GitHub

• Please use the 👍 reaction to show that you are interested into the same feature.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Steps

1. Go to go to index.php/settings/user/theming
2. Select one of the following default offered backgrounds: All that make the font color go black

• Pink bubbles
• Yellow bricks
• Lion rock hill
• "the ducks"
• soft floral
• morning fog

4. Open the notification menu => Inverted color ❌
5. Open the contact search => menu opens in place of the button instead of a popover menu 💥
   

How it looks with any other background:

[ShGKme]

• Regression of fix header-elements being not shown correctly #42712

While filter inverts the icon, it also breaks the whole header menu.

Without filter	With filter

[szaimen]

Yeah, I wonder how a simple filter can do this??? Browser bug maybe?

[ShGKme]

Yeah, I wonder how a simple filter can do this??? Browser bug maybe?

Anyway, we should not invert a whole menu. Only the icon.

[szaimen]

Anyway, we should not invert a whole menu. Only the icon.

I agree.

[szaimen]

Fix is in #42962

I am not really satisfied with the solution but it is what it is...

[blizzz]

Fix is in #42962

Or maybe #42963

[szaimen]

Fix is in #42962

Or maybe #42963

Yes, sorry

[ChristophWurst]

It's not just a visual bug. I see a network request to load the content of the menu even before it opens. That should only happen on click.

[ChristophWurst]

Test master. The menu is still as broken as it was before for me:

The POST /contactsmenu/contacts also happens after page load, before I event click on the contacts menu toggle.

[szaimen]

@ChristophWurst apparently someone forgot to recompile css and our CI didnt catch that... See #43017

[ChristophWurst]

The POST /contactsmenu/contacts also happens after page load, before I event click on the contacts menu toggle.

Is still there, even after recompilation.

[szaimen]

The POST /contactsmenu/contacts also happens after page load, before I event click on the contacts menu toggle.

Is still there, even after recompilation.

See #43018