[Bug]: 30.0.0 share by email - no email is sent #48012

himpierre · 2024-09-15T12:52:32Z

⚠️ This issue respects the following points: ⚠️

This is a bug, not a question or a configuration/webserver/proxy issue.
This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
I agree to follow Nextcloud's Code of Conduct.

Bug description

Hello Devs.

After updating to 30.0.0 sharing files via email does not work as it is supposed to I guess. There is no mail being sent to the sharee. So the one I try to share the files with is not getting notified. Nothing in the logs.
Email in general works. Invitations for talk go out.

Steps to reproduce

Share file via Email
Save
No email to the sharee

Expected behavior

Sharee gets notified.

Nextcloud Server version

master

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 28 to 29)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Default user-backend (database)
LDAP/ Active Directory
SSO - SAML
Other

Configuration report

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "30.0.0.14",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "maintenance_window_start": 3,
        "theme": "",
        "trusted_domains": [
            "fluffycloud.de"
        ],
        "mail_smtpmode": "sendmail",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "loglevel": 2,
        "log_rotate_size": 104857600,
        "filelocking.enabled": true,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0
        },
        "htaccess.RewriteBase": "\/",
        "updater.release.channel": "stable",
        "preview_max_filesize_image": -1,
        "overwrite.cli.url": "https:\/\/fluffycloud.de\/",
        "mysql.utf8mb4": true,
        "default_phone_region": "DE",
        "defaultapp": "files",
        "app_install_overwrite": [
            "calendar",
            "groupfolders",
            "mail",
            "spreed",
            "passman",
            "audioplayer",
            "polls",
            "passwords",
            "breezedark"
        ]
    }
}

List of activated Apps

Enabled:
  - activity: 3.0.0
  - admin_audit: 1.20.0
  - calendar: 5.0.0
  - cloud_federation_api: 1.13.0
  - comments: 1.20.1
  - contacts: 6.1.0
  - contactsinteraction: 1.11.0
  - dashboard: 7.10.0
  - dav: 1.31.1
  - federatedfilesharing: 1.20.0
  - files: 2.2.0
  - files_downloadlimit: 3.0.0
  - files_external: 1.22.0
  - files_pdfviewer: 3.0.0
  - files_reminders: 1.3.0
  - files_sharing: 1.22.0
  - files_trashbin: 1.20.1
  - files_versions: 1.23.0
  - firstrunwizard: 3.0.0
  - logreader: 3.0.0
  - lookup_server_connector: 1.18.0
  - nextcloud_announcements: 2.0.0
  - notes: 4.10.1
  - notifications: 3.0.0
  - oauth2: 1.18.1
  - oidc: 0.9.4
  - password_policy: 2.0.0
  - passwords: 2024.7.20
  - photos: 3.0.2
  - polls: 7.2.3
  - privacy: 2.0.0
  - provisioning_api: 1.20.0
  - recommendations: 3.0.0
  - related_resources: 1.5.0
  - richdocuments: 8.5.0
  - serverinfo: 2.0.0
  - settings: 1.13.0
  - sharebymail: 1.20.0
  - spreed: 20.0.0
  - support: 2.0.0
  - survey_client: 2.0.0
  - systemtags: 1.20.0
  - text: 4.1.0
  - theming: 2.5.0
  - twofactor_backupcodes: 1.19.0
  - updatenotification: 1.20.0
  - user_status: 1.10.0
  - viewer: 3.0.0
  - weather_status: 1.10.0
  - webhook_listeners: 1.1.0-dev
  - workflowengine: 2.12.0
Disabled:
  - bruteforcesettings: 3.0.0 (installed 2.4.0)
  - circles: 30.0.0-dev (installed 27.0.0)
  - encryption: 2.18.0
  - federation: 1.20.0 (installed 1.17.0)
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - groupfolders: 18.0.1 (installed 18.0.1)
  - secrets: 2.0.3 (installed 2.0.3)
  - suspicious_login: 8.0.0
  - twofactor_nextcloud_notification: 4.0.0
  - twofactor_totp: 12.0.0-dev (installed 5.0.0)
  - user_ldap: 1.21.0
  - whiteboard: 1.0.1 (installed 1.0.1)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

No response

Bad-and-Mad · 2024-09-16T10:35:21Z

The same here. But the function is essential for me (and probably for others too).

hxcde · 2024-09-17T09:49:13Z

The same here. But the function is essential for me (and probably for others too).

Yes its the only usecase for our company. Same problem here, just restored the old version from backup and waiting for the fix.

Bad-and-Mad · 2024-09-17T10:30:56Z

The same here. But the function is essential for me (and probably for others too).

Yes its the only usecase for our company. Same problem here, just restored the old version from backup and waiting for the fix.

Lucky you. In our case, by the time I realized it, so much data had been changed that it no longer made sense to restore the backups for a downgrade. Unfortunately, I now have to wait for the error to be rectified. However, I cannot understand why such an important function for a version release was not tested extensively. My OpenOffice connection also only works if I change the program code. After that, however, the mail app no longer works. None of the last releases have caused so much trouble.

daveatpinellas · 2024-09-17T18:35:52Z

Confirmed this is broken in 30.0.0. The [ Send Email ] button to test smtp works. However when you share a file by email address, the outside user never gets email. Confirmed that email is bouncing correctly to this same smtp host at the operating system level.

Bad-and-Mad · 2024-09-24T11:14:23Z

Here is my log (level 0):

"Share notification not sent because mailsend is false."

{"reqId":"MVHwqqQbuNmAEozOhw5i","level":0,"time":"2024-09-24T12:54:28+02:00","remoteAddr":"x.x.x.x","user":"xyz","app":"share","method":"POST","url":"/ocs/v2.php/apps/files_sharing/api/v1/shares","message":"Share notification not sent because mailsend is false.","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36","version":"30.0.0.14","data":{"app":"share"}}

himpierre · 2024-09-24T12:06:02Z

Hello Devs!

Is there maybe a patch or workaround we can try until this is fixed?

cheers!

Bad-and-Mad · 2024-09-26T05:05:29Z

Dear developers, is there anyone who can tell us how to set mailsend to true? There must be a way in the code to influence this logical state, as it is also queried and evaluated by the sharing api.

Orobas42 · 2024-09-26T05:39:12Z

This issue deserves urgent attention. The email sharing function is a critical feature of Nextcloud, and we are now two weeks into a stable release with this functionality broken.

I've observed an additional detail that may be helpful for troubleshooting:
When creating a new share, no email is sent to the recipient. However, if we edit an existing share (e.g., change the password or add a comment), emails are successfully sent.

This behavior suggests that the email sending mechanism itself is working, but there's a specific issue with the initial share creation process. Can the development team please investigate this discrepancy?

Given the importance of this feature for many users and organizations, we urgently need an update on the status of this bug and an estimated timeline for a fix. In the meantime, are there any workarounds that can be implemented to restore this functionality? If there's a specific commit that introduced this issue, would it be possible to temporarily revert that commit as a quick fix until a proper solution is developed?

Bad-and-Mad · 2024-09-26T06:09:16Z

The quick and dirty customization that works for me. But the function is essential for us.

File: NC_DIR/lib/private/Share20/Share.php

From line 590

        public function getMailSend() {
                // by M.W.
                // return $this->mailSend;
                return true;
        }

Orobas42 · 2024-09-26T06:39:01Z

This is really dirty. You shouldn't do it in the getter function, as this is also called in other places. The “better” dirty way is to set it to true at the actual place in the code.

File: /lib/private/Share20/Manager.php
Line 740:

//if ($share->getMailSend()) {
if (true) {

Thats the place where the message “Share notification not sent because mailsend is false.” is raised.

But it's still the most dirty workaround in my opinion. What happens when you share with nc users or just want to share a link?

Bad-and-Mad · 2024-09-26T08:36:20Z

Better dirty is always possible. In any case, for now there is a solution that will help many people here who are dependent on the function. I don't want to wait another two weeks. And it is confirmed again and again: don't use a 0 version on productive systems.

nfebe · 2024-09-26T09:41:17Z

Better dirty is always possible. In any case, for now there is a solution that will help many people here who are dependent on the function. I don't want to wait another two weeks. And it is confirmed again and again: don't use a 0 version on productive systems.

Hello @Bad-and-Mad sorry you have had to deal with this for a while, this shall be fixed by the next release.

Bad-and-Mad · 2024-09-26T10:02:17Z

Hello @Bad-and-Mad sorry you have had to deal with this for a while, this shall be fixed by the next release.

I assumed that the problem would be fixed in the next version, but for all those who have upgraded to version 30, a solution is needed for such an important function. Nobody knows when version 30.0.1 will be released and whether the problem will really have disappeared. I just hope that the change in the program code does not cause any further problems.

It looks like, the frontend it needs to provide the `sendMail` param for the backend to decide wether mails would be sent. Our UI does not have that at the moment so it should default to sending emails always for mail shares. Not exactly sure how this was handled earlier but this is a good starting point. Resolves : #48012 Signed-off-by: fenn-cs <[email protected]>

Bad-and-Mad · 2024-09-26T11:50:12Z

Addendum: The program should not search for logical specifications that nobody can set...neither in the web frontend nor in the config.php.

It looks like, the frontend it needs to provide the `sendMail` param for the backend to decide wether mails would be sent. Our UI does not have that at the moment so it should default to sending emails always for mail shares. Not exactly sure how this was handled earlier but this is a good starting point. Resolves : #48012 Signed-off-by: fenn-cs <[email protected]>

dd4y · 2024-11-05T14:05:00Z

Hello,

My implementation also relies heavily on this feature. I confirm that is it son functioning in 30.0.1.

tigernero79 · 2024-11-06T17:30:32Z

I have this problem in both a 30.0.1 and 30.0.2 rc2 instance. Is there a manual fix that can be done while waiting for a solution?

DerDP · 2024-11-06T18:13:13Z

I have this problem in both a 30.0.1 and 30.0.2 rc2 instance. Is there a manual fix that can be done while waiting for a solution?

Workaround from @Bad-and-Mad works for me.
#48012 (comment)

tigernero79 · 2024-11-06T18:52:20Z

I don't understand if the line should be removed or modified in the file manager.php

DerDP · 2024-11-06T18:55:01Z

I don't understand if the line should be removed or modified in the file manager.php

Modified. In his example he commented out the old if statement and add new one.

nfebe · 2024-11-07T06:17:10Z

I have this problem in both a 30.0.1 and 30.0.2 rc2 instance. Is there a manual fix that can be done while waiting for a solution?

We do not expect to see this issue as from 30.0.2 rc1

tigernero79 · 2024-11-07T08:47:13Z

and yet I updated from 30.0.2 rc2 and the problem continues. given the changes made to the file, perhaps the file should also be modified?

File: /lib/private/Share20/Manager.php
now Line 752:

//if ($share->getMailSend()) {
if (true) {

LM-vb · 2024-11-07T09:41:26Z

Can someone else test it using 30.0.2 rc2?

I intended to do the upgrade to 30.0.2 once it is released, but if this major function is still broken I will postpone the upgrade.

himpierre · 2024-11-07T10:26:13Z

Just checked. Works for me with 30.0.2. Thanks Devs! Am 7. November 2024 10:41:51 MEZ schrieb LM-vb ***@***.***>:

…

Can someone else test it using 30.0.2 rc2? I intended to do the upgrade to 30.0.2 once it is released, but if this major function is still broken I will postpone the upgrade.

tigernero79 · 2024-11-07T16:22:30Z

I updated to 30.0.2 final and still I only receive notifications if I rename files or folders, and nothing more

if I try to upload or delete some files or folders I don't receive any notification via email

the bug is still there

LM-vb · 2024-11-07T17:30:55Z

I agreee with @tigernero79. I, too, only get an email notification when renaming a file, not if a new file gets uploaded into a shared folder. This used to work before (<= NC 29). However, the issue of the bug addressed in this bug report #48012 has been fixed.

@tigernero79: I think you should open a new bug report addressing the new issue.

tigernero79 · 2024-11-07T17:41:38Z

#49133

ticket open

thanks

himpierre added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Sep 15, 2024

solracsf added the 30-feedback label Sep 15, 2024

sorbaugh added the regression label Sep 15, 2024

nfebe self-assigned this Sep 15, 2024

nfebe added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 15, 2024

szaimen mentioned this issue Sep 26, 2024

update existing instances to Nextcloud 30 nextcloud/all-in-one#5249

Closed

34 tasks

nfebe mentioned this issue Sep 26, 2024

fix(ShareAPI): Send mails for mail shares by default #48381

Merged

1 task

nfebe added the 2. developing Work in progress label Oct 24, 2024

nfebe closed this as completed in #48381 Oct 24, 2024

nfebe removed 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress labels Oct 24, 2024

nfebe added this to 📁 Files team Oct 24, 2024

nfebe moved this to ☑️ Done in 📁 Files team Oct 24, 2024

nfebe added this to the Nextcloud 30.0.2 milestone Oct 24, 2024

skjnldsv mentioned this issue Oct 29, 2024

[Bug]: link shared by email no longer works #48908

Closed

8 tasks

joshtrichards added feature: sharing feature: emails labels Oct 29, 2024

joshtrichards mentioned this issue Nov 5, 2024

[Bug]: No Email Notifications Sent for Folder Shares in Nextcloud Hub 9 (30.0.1) #49074

Closed

8 tasks

tigernero79 mentioned this issue Nov 7, 2024

[Bug]: versions 30.0.2 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed #49133

Closed

8 tasks

nextcloud locked as resolved and limited conversation to collaborators Nov 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: 30.0.0 share by email - no email is sent #48012

[Bug]: 30.0.0 share by email - no email is sent #48012

himpierre commented Sep 15, 2024

Bad-and-Mad commented Sep 16, 2024

hxcde commented Sep 17, 2024

Bad-and-Mad commented Sep 17, 2024

daveatpinellas commented Sep 17, 2024

Bad-and-Mad commented Sep 24, 2024

himpierre commented Sep 24, 2024

Bad-and-Mad commented Sep 26, 2024

Orobas42 commented Sep 26, 2024

Bad-and-Mad commented Sep 26, 2024 •

edited

Loading

Orobas42 commented Sep 26, 2024

Bad-and-Mad commented Sep 26, 2024

nfebe commented Sep 26, 2024 •

edited

Loading

Bad-and-Mad commented Sep 26, 2024

Bad-and-Mad commented Sep 26, 2024

dd4y commented Nov 5, 2024

tigernero79 commented Nov 6, 2024

DerDP commented Nov 6, 2024

tigernero79 commented Nov 6, 2024

DerDP commented Nov 6, 2024

nfebe commented Nov 7, 2024

tigernero79 commented Nov 7, 2024

LM-vb commented Nov 7, 2024

himpierre commented Nov 7, 2024 via email

tigernero79 commented Nov 7, 2024

LM-vb commented Nov 7, 2024

tigernero79 commented Nov 7, 2024

[Bug]: 30.0.0 share by email - no email is sent #48012

[Bug]: 30.0.0 share by email - no email is sent #48012

Comments

himpierre commented Sep 15, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Steps to reproduce

Expected behavior

Nextcloud Server version

Operating system

PHP engine version

Web server

Database engine version

Is this bug present after an update or on a fresh install?

Are you using the Nextcloud Server Encryption module?

What user-backends are you using?

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

Bad-and-Mad commented Sep 16, 2024

hxcde commented Sep 17, 2024

Bad-and-Mad commented Sep 17, 2024

daveatpinellas commented Sep 17, 2024

Bad-and-Mad commented Sep 24, 2024

himpierre commented Sep 24, 2024

Bad-and-Mad commented Sep 26, 2024

Orobas42 commented Sep 26, 2024

Bad-and-Mad commented Sep 26, 2024 • edited Loading

Orobas42 commented Sep 26, 2024

Bad-and-Mad commented Sep 26, 2024

nfebe commented Sep 26, 2024 • edited Loading

Bad-and-Mad commented Sep 26, 2024

Bad-and-Mad commented Sep 26, 2024

dd4y commented Nov 5, 2024

tigernero79 commented Nov 6, 2024

DerDP commented Nov 6, 2024

tigernero79 commented Nov 6, 2024

DerDP commented Nov 6, 2024

nfebe commented Nov 7, 2024

tigernero79 commented Nov 7, 2024

LM-vb commented Nov 7, 2024

himpierre commented Nov 7, 2024 via email

tigernero79 commented Nov 7, 2024

LM-vb commented Nov 7, 2024

tigernero79 commented Nov 7, 2024

Bad-and-Mad commented Sep 26, 2024 •

edited

Loading

nfebe commented Sep 26, 2024 •

edited

Loading