feat(core): Expose the confirm password endpoint #43000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
nickvergessen,
ChristophWurst,
juliusknorr,
kesselb,
skjnldsv and
come-nc
nickvergessen
requested changes
Jan 21, 2024
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
feat/core/expose-confirm-password-endpoint
branch
from
fa8f01d to
a84c71d
Compare
come-nc
approved these changes
Jan 22, 2024
nickvergessen
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Sending auth data should pass the password check:
server/lib/private/User/Session.php
Line 605 in 7f2fdd8
The problem is you are sending auth + cookies, so we use the cookies only and the line above is never ran. We should fix the PasswordConfirmMiddleware to check if auth data was provided with the request.
|
My testing confirms:
|
4 tasks
provokateurin
restored the
feat/core/expose-confirm-password-endpoint
branch
|
After the discussions in #43034 we came to the conclusion that this PR makes more sense and is less susceptible to any additional security holes the other PR could open up. |
|
Bleh should have re-opened before pushing, will create a new PR |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows non-web clients to confirm the password in order to use endpoints that require it.
Checklist