Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap versions list in virtual scroll #43029

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Wrap versions list in virtual scroll #43029

merged 2 commits into from
Jan 23, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jan 22, 2024 •
edited
Loading

Prevent initially loading as many previews as there are versions

Virtual scroll component copied from the Photos app.

@artonge artonge self-assigned this Jan 22, 2024
@artonge artonge requested review from susnux, skjnldsv and Pytal January 22, 2024 16:07
@artonge artonge added this to the Nextcloud 29 milestone Jan 22, 2024
@susnux
Copy link
Contributor

susnux commented Jan 22, 2024

I "like" how we got at least 4 different virtual scrolling components 😅
(this one / photos, the one in the files app, the one in the users list and the logreader one)

@artonge
Copy link
Contributor Author

artonge commented Jan 23, 2024

I "like" how we got at least 4 different virtual scrolling components 😅

And that is only from the Files related apps. Talk is probably using one, and other apps as well. We should probably add one in the @nc/vue at some point.

@artonge artonge force-pushed the artonge/feat/files_versions_virtual_scroll branch 2 times, most recently from 3ffb0dc to df77a3c Compare January 23, 2024 10:53
@artonge artonge requested review from skjnldsv and a team January 23, 2024 11:41
@emoral435
Copy link
Contributor

Overall, nothing really breaking here. I can confirm and accept PR if needed @artonge, just tag me and LMK! :)

@artonge
Wrap versions list in virtual scroll
5302024 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
Compile assets
16265db 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/files_versions_virtual_scroll branch from df77a3c to 16265db Compare January 23, 2024 14:57
@artonge artonge requested a review from emoral435 January 23, 2024 15:36
susnux
susnux approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice piece!

apps/files_versions/src/components/VirtualScrolling.vue Show resolved Hide resolved
@blizzz
Copy link
Member

blizzz commented Jan 23, 2024

/backport to stable28

@artonge artonge merged commit 2ac1d86 into master Jan 23, 2024
45 checks passed
@artonge artonge deleted the artonge/feat/files_versions_virtual_scroll branch January 23, 2024 16:52
@backportbot backportbot bot mentioned this pull request Jan 23, 2024
Merged
2 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz left review comments

@susnux susnux susnux approved these changes

@emoral435 emoral435 emoral435 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews enhancement feature: versions javascript
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
5 participants
@artonge @susnux @emoral435 @blizzz @skjnldsv