-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dav): don't crash subscription on invalid calendar object #48349
Conversation
Thanks for your pull request 👍 |
3714b00
to
20b3d3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@escoand only one issue you need to sign the PR.
Signed-off-by: escoand <[email protected]>
@SebastianKrupinski done. |
To fix the failing tests:
|
@escoand... @kesselb is correct due to the change from a error to a warning our ci unit tests are failing...
Do you mind adjusting them? The file is "apps/dav/tests/unit/CalDAV/WebcalCaching/RefreshWebcalServiceTest.php" line 255 and 305. Both lines should be "->method('warning')" Thanks! I would do it for you but its a bit of a pain because you are on a forked patch. |
Signed-off-by: escoand <[email protected]>
Thanks again. Cherry-picked your commits into #48519. A part of our CI is skipped for forks because they don't work currently, but some of the skipped workflows are required to merge a pr 🙈 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
I had two different problems here when subscribing to an external calendar.
When importing the same calendar these wrong objects get skipped.
But subscribing crashes at this point completely causing a partially imported calendar.
Nextcloud 29.0.7 is not affected.
and
TODO
Checklist