Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replace Twitter & Diaspora links and text #48520

Merged
merged 8 commits into from
Oct 8, 2024
Merged

chore: Replace Twitter & Diaspora links and text #48520

merged 8 commits into from
Oct 8, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Oct 2, 2024 •
edited
Loading

  • Use Twitters new name "X"
  • Remove Diaspora social and include Mastodon instead

Resolves : #48409

Screenshots

Before
Screenshot from 2024-10-02 11-09-44
After
Screenshot from 2024-10-02 11-48-12

@nfebe nfebe added the 2. developing Work in progress label Oct 2, 2024
@nfebe nfebe force-pushed the chore/48409/replace-diaspora-and-twitter branch from 3804cbd to a539a56 Compare October 2, 2024 09:53
@nfebe nfebe marked this pull request as ready for review October 2, 2024 09:53
@nfebe nfebe added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 2, 2024
@nfebe
Copy link
Contributor Author

nfebe commented Oct 2, 2024

/backport to stable30

@nfebe nfebe force-pushed the chore/48409/replace-diaspora-and-twitter branch from a539a56 to 04cacc3 Compare October 2, 2024 09:58
@nfebe
Copy link
Contributor Author

nfebe commented Oct 2, 2024

/compile

@nfebe nfebe enabled auto-merge October 2, 2024 09:59
@nfebe nfebe force-pushed the chore/48409/replace-diaspora-and-twitter branch from 9620778 to f8483ed Compare October 2, 2024 12:47
@nfebe nfebe requested review from provokateurin and artonge October 2, 2024 12:47
@nfebe nfebe force-pushed the chore/48409/replace-diaspora-and-twitter branch 2 times, most recently from e99060a to c4e5566 Compare October 7, 2024 06:51
@susnux susnux force-pushed the chore/48409/replace-diaspora-and-twitter branch from c4e5566 to 37ffe36 Compare October 7, 2024 16:28
susnux
susnux approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just replaced the icons with the proper ones from core/img for legal reasons.

Screenshot 2024-10-07 at 18-14-26 Sharing - Personal settings - Nextcloud
Screenshot 2024-10-07 at 18-14-18 Sharing - Personal settings - Nextcloud

@susnux susnux force-pushed the chore/48409/replace-diaspora-and-twitter branch from 37ffe36 to 4342a44 Compare October 7, 2024 16:30
@susnux susnux force-pushed the chore/48409/replace-diaspora-and-twitter branch from 4f4a68b to 64eec9d Compare October 7, 2024 18:48
@susnux
Copy link
Contributor

susnux commented Oct 7, 2024

/compile

nfebe and others added 8 commits October 8, 2024 14:31
@nfebe @susnux
chore: Replace Twitter & Diaspora links and text
cacfa5d 
- Use Twitters new name "X"
- Remove Diaspora social and include Mastodon instead

Resolves : #48409

Signed-off-by: fenn-cs <[email protected]>
@susnux
fix(core): Use correct facebook icon provided by Meta
f9d3954 
The legal terms require to exactly use the facebook logo as provided by Meta.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
feat(core): Add correct X logo as provided by X Corp.
38cd9d3 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(federatedfilessharing): Use social media icons from core rather t…
52cfac5 
…han inline SVGs

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
refactor(federatedfilessharing): Make copy logic more resilient and u…
af9d716 
…se Typescript

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(federatedfilesharing): Add aria label to include the X in `X (f…
268aad3 
…ormerly Twitter)` button.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(federatedfilesharing): Use valid mastodon URL for sharing
30e02f2 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@nextcloud-command @susnux
chore(assets): Recompile assets
9741456 
Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux force-pushed the chore/48409/replace-diaspora-and-twitter branch from 60cf975 to 9741456 Compare October 8, 2024 12:31
@nfebe nfebe merged commit 50b8221 into master Oct 8, 2024
118 checks passed
@nfebe nfebe deleted the chore/48409/replace-diaspora-and-twitter branch October 8, 2024 19:02
@backportbot backportbot bot mentioned this pull request Oct 8, 2024
Merged
2 tasks
@susnux susnux restored the chore/48409/replace-diaspora-and-twitter branch October 8, 2024 19:06
@susnux susnux deleted the chore/48409/replace-diaspora-and-twitter branch October 8, 2024 19:11
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@provokateurin provokateurin provokateurin approved these changes

@szaimen szaimen Awaiting requested review from szaimen

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews feedback-requested
Projects
📁 Files team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharing settings: Replace Diaspora and Twitter with Mastodon and X
6 participants
@nfebe @susnux @artonge @provokateurin @szaimen @nextcloud-command