Disable/hide share edit options when user can not edit the share #49747
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
a team,
artonge,
Pytal and
sorbaugh
and removed request for
a team
provokateurin
changed the title
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
artonge
approved these changes
Dec 10, 2024
|
/compile |
skjnldsv
approved these changes
Dec 10, 2024
Signed-off-by: provokateurin <[email protected]>
… can not edit share Signed-off-by: provokateurin <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
skjnldsv
force-pushed
the
fix/files_sharing/disable-editing
branch
from
e9e6af8 to
3a64092
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/49747/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1e44c671 f2898df2 3a640929
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49747/stable27Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Dec 10, 2024
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were still showing the user the options to edit and delete the share, but they will face an unhelpful error message when they try to continue.
Before:
After:
We could also hide the quick edit button, but I think it's nice to leave it there to still indicate the permission of the share, even if the current user can not change them.
Checklist