Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make files settings admin configurable #49758

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bromiesTM
Copy link

@bromiesTM bromiesTM commented Dec 10, 2024

Summary

To set the config run

ooc config:app:set --value <yes/no> files crop_image_previews
ooc config:app:set --value <yes/no> files show_hidden
ooc config:app:set --value <yes/no> files sort_favorites_first
ooc config:app:set --value <yes/no> files sort_folders_first
ooc config:app:set --value <yes/no> files grid_view
ooc config:app:set --value <yes/no> files folder_tree

Checklist

Not ok: in_array("foo", [true, false]); // returns true
ok: in_array("foo", [true, false], true); // returns false

Signed-off-by: Misha M.-Kupriyanov <[email protected]>

public function __construct(
protected IConfig $config,
IUserSession $userSession,
IAppConfig $appConfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Contructor property promotion

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bromiesTM bromiesTM force-pushed the kh/feat/configurable-files-settings branch from f673671 to 35d852d Compare December 11, 2024 08:22
@bromiesTM bromiesTM marked this pull request as ready for review December 11, 2024 08:25
@bromiesTM bromiesTM marked this pull request as draft December 11, 2024 10:32
@bromiesTM
Copy link
Author

🚧 Switched back to draft to make the settings less aggressive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants