Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save shared files #2331

Closed
tigermick opened this issue Aug 24, 2022 · 11 comments · Fixed by #3416
Closed

save shared files #2331

tigermick opened this issue Aug 24, 2022 · 11 comments · Fixed by #3416
Labels
discussion Being discussed enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@tigermick
Copy link

Talk is a great app to talk with other users on nextcloud but i think one feature is missing when you share files.
You can show a picture for example but if you want to save its, this is hard ...
You just can share its ...

Describe the solution you'd like
Can you add an option below "share" in menu to save file ?

Maybe necessary to add a setting to have a default folder to save files in nextcloud setting too.

@tigermick tigermick added 0. Needs triage enhancement New feature or request labels Aug 24, 2022
@timkrueger timkrueger added the discussion Being discussed label Aug 29, 2022
@timkrueger
Copy link
Contributor

With the share sheet it is already possible to save files shared in a conversation. If you want to save them in your Nextcloud, NC Files for Android must be installed.

Beside that all with you shared files are accessible in the /Talk directory in the users directory.

@tigermick
Copy link
Author

I know another solution is possible to save shared file like with nextcloud app in talk folder ... But it's just simplier et quicker to have "save" option when you preview file in talk, isn't it ?

@timkrueger
Copy link
Contributor

timkrueger commented Aug 30, 2022

Currently the workflow to save something into your Nextcloud is:

View file in full-screen -> select share -> select Nextcloud Files (or other target app) -> select target folder

With a specific save (to Nextcloud) it looks like that:

View file in full-screen -> select share  -> select target folder

One interaction will be removed with this change. But for that we must change the scope of the Talk app into the direction of file management. But in my view that is the domain of the Files app.

//cc @mahibi

@mahibi
Copy link
Collaborator

mahibi commented Sep 1, 2022

i guess you want a save button next to the share button? @tigermick
So in whatsapp there is this save button which saves the file to the public visible folder of the app so it also appears in the systems gallery app.

@tigermick
Copy link
Author

@mahibi You could have something like this :
Screenshot_20220904-233512_Talk
With this choice, default file browser open to prompt user to choice a path to download a picture for example on his phone.
Currently, I use this application : https://f-droid.org/fr/packages/xyz.myachin.saveto/ to have possibility to save a file in my phone if i don't want go to look for in talk folder in nextcloud android app.

@mahibi
Copy link
Collaborator

mahibi commented Sep 5, 2022

i like this, but might need to be discussed if we want this, especially privacy-wise. cc @AndyScherzinger
The main purpose of people using this will be that other apps can access the files (see https://developer.android.com/training/data-storage/shared). However other users want to avoid that data is accessible to other apps and may not understand the impact of this feature. So at least there should be some hint with a privacy warning.

@gerbrent
Copy link

I was just searching for this function today without any luck.
My use case: save a file from a conversation for long-term archiving.

Rational for expecting it: Every other arguably privacy-conscious app in this space I've used has implemented a save feature (Signal, SimpleX, Element) despite some also having the above hesitation (i.e. Signal in it's infancy..)

other users want to avoid that data is accessible to other apps and may not understand the impact of this feature

My thought process immediately upon not finding a save feature was "how can I game the share feature to accomplish what I want - that is save the file to local storage for backing up? The answer of this workaround then becomes: use the share function to share it with literally any other app installed on my phone that can handle this file type, whether privacy-conscious or not. Then save from there.

So, I'm not sure the lack of a save function is preventing privacy leaks. Arguably it may even be increasing privacy leaks..

So, there is my humble argument why a save feature would be a wonderful UX addition..

@gerbrent
Copy link

gerbrent commented Aug 26, 2023

If implemented, should consider also adding the functionality to the long-click menu:
(related: #3276 )

image

@gerbrent
Copy link

An example of a privacy-conscious warning message in Signal when saving a photo to local storage:

Screenshot_20230826-173843_Signal

@TBI-NS
Copy link

TBI-NS commented Aug 28, 2023

This feature is available on iOS and everyone is happy to be able to import a shared photo into the photo gallery without having to share from one app to another.

It's an essential feature and I think finding methods B or C is not an appropriate response.

The only viable solution is:

Long press on the photo >> save to photo gallery

Or

Tap on the photo >> full-screen image >> menu at the top right >> save to photo gallery.

@gerbrent
Copy link

gerbrent commented Nov 8, 2023

🎉

This is amazing, thank you all who made it possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Being discussed enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants