Add permanent warning when notifications are not set up correctly #4476

mahibi · 2024-11-22T16:24:49Z

Show a warning whenever something regarding notifications is not set up correctly.

known bug is #4484 (won't be fixed for now if no one comes up with an idea..)

🖼️ Screenshots/ Videos

Warning when notifications are not set up correctly

On first login, ask directly with popups for notification permission and to ignore battery optimization.
If this is declined or any other setting is wrong, show a permanent warning.
- Also: When using mobile device management MDM, it may happen that some permissions are not set up while preparing the phones and users won't see any dialogs on first use. With this change, they now see the permanent warning and are guided what changes need to be made.
When clicking on the warning, settings are opened and things that need to be changed will blink and have red subtitles.
When any permission is revoked it will show a warning again in conversation list.
Allow user to disable the warning in conversation list if anything is wrong.
If a server has no notification app installed, this will be shown for the regarding account.

notAllowAllPermissionsOnStart.mp4

When logging in and allowing all permissions, no warning is necessary.

allowAllPermissionsOnStart.mp4

🏁 Checklist

⛑️ Tests (unit and/or integration) are included or not needed
🔖 Capability is checked or not needed
🔙 Backport requests are created or not needed: /backport to stable-xx.x
📅 Milestone is set
🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

mahibi · 2024-11-22T16:40:59Z

/backport to stable-20.0

app/src/main/res/values/strings.xml

Also add an option to not show the hint, when user doesn't want to ignore battery optimization. Only show these features when gplay services are available. Otherwise don't show them as it would pretend notifications would be possible without gplay. Signed-off-by: Marcel Hibbe <[email protected]>

…on is enabled Open notification settings when click on warning Also, still offer to enable notifications and disable battery optimization on first install Signed-off-by: Marcel Hibbe <[email protected]>

…log for asking direct permission was not shown by android Signed-off-by: Marcel Hibbe <[email protected]>

… is is not permitted. Otherwise user can't enable them anyway Signed-off-by: Marcel Hibbe <[email protected]>

Signed-off-by: Marcel Hibbe <[email protected]>

github-actions · 2024-11-26T14:33:50Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4476-talk.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

github-actions · 2024-11-26T14:34:29Z

Codacy

Lint

Type	master	PR
Warnings	94	158
Errors	132	76

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	16	16
Dodgy code	71	71
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	104	104

Lint increased!

mahibi added this to the 20.1.0 milestone Nov 22, 2024

mahibi self-assigned this Nov 22, 2024

mahibi added the 3. to review Waiting for reviews label Nov 22, 2024

backportbot bot added the backport-request label Nov 22, 2024

mahibi requested review from rapterjet2004, sowjanyakch, nickvergessen and Antreesy November 22, 2024 16:41

This comment was marked as outdated.

Sign in to view

mahibi added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 25, 2024

mahibi marked this pull request as draft November 25, 2024 09:37

mahibi force-pushed the featue/noid/addIgnoreBatteryOptimizationHint branch from f392cac to 096b361 Compare November 25, 2024 23:05

This comment was marked as outdated.

Sign in to view

mahibi changed the title ~~Add permanent hint when battery optimization is not ignored~~ Add permanent warning when notifications are not set up correctly Nov 26, 2024

mahibi added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 26, 2024

mahibi marked this pull request as ready for review November 26, 2024 12:38

nickvergessen reviewed Nov 26, 2024

View reviewed changes

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved

mahibi mentioned this pull request Nov 26, 2024

Crash when revoking notification permission #4484

Open

rapterjet2004 approved these changes Nov 26, 2024

View reviewed changes

sowjanyakch approved these changes Nov 26, 2024

View reviewed changes

mahibi added 6 commits November 26, 2024 15:24

Show a warning if notifications are not allowed or battery optimizati…

b1e550b

…on is enabled Open notification settings when click on warning Also, still offer to enable notifications and disable battery optimization on first install Signed-off-by: Marcel Hibbe <[email protected]>

open full notification settings from talk settings as fallback if dia…

b63325a

…log for asking direct permission was not shown by android Signed-off-by: Marcel Hibbe <[email protected]>

disable sound notification settings when main notification permission…

c2b99c5

… is is not permitted. Otherwise user can't enable them anyway Signed-off-by: Marcel Hibbe <[email protected]>

fix to hide notification setting for generic build variant

a9ec8c2

Signed-off-by: Marcel Hibbe <[email protected]>

blink items when opened by notification warning

fa70cff

Signed-off-by: Marcel Hibbe <[email protected]>

mahibi added 5 commits November 26, 2024 15:24

blink notification channels

c559c6b

Signed-off-by: Marcel Hibbe <[email protected]>

add check if server notification app is installed for current user

6f6c189

Signed-off-by: Marcel Hibbe <[email protected]>

extract blink method, move server notification app hint to gplay block

8e6072b

Signed-off-by: Marcel Hibbe <[email protected]>

reformat code

c7fd94b

Signed-off-by: Marcel Hibbe <[email protected]>

change strings in notification settings

6dc52fe

Signed-off-by: Marcel Hibbe <[email protected]>

mahibi force-pushed the featue/noid/addIgnoreBatteryOptimizationHint branch from 7a9c281 to 6dc52fe Compare November 26, 2024 14:25

nickvergessen self-requested a review November 26, 2024 14:26

nickvergessen approved these changes Nov 26, 2024

View reviewed changes

mahibi merged commit f048dc9 into master Nov 26, 2024
13 of 16 checks passed

mahibi deleted the featue/noid/addIgnoreBatteryOptimizationHint branch November 26, 2024 14:37

backportbot bot mentioned this pull request Nov 26, 2024

[stable-20.0] Add permanent warning when notifications are not set up correctly #4485

Closed

2 tasks

backportbot bot removed the backport-request label Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add permanent warning when notifications are not set up correctly #4476

Add permanent warning when notifications are not set up correctly #4476

mahibi commented Nov 22, 2024 •

edited

Loading

mahibi commented Nov 22, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

Add permanent warning when notifications are not set up correctly #4476

Add permanent warning when notifications are not set up correctly #4476

Conversation

mahibi commented Nov 22, 2024 • edited Loading

🖼️ Screenshots/ Videos

🏁 Checklist

mahibi commented Nov 22, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

Codacy

Lint

SpotBugs

Lint increased!

mahibi commented Nov 22, 2024 •

edited

Loading