Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of office #4521

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Out of office #4521

wants to merge 22 commits into from

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Dec 5, 2024

Resolve #4477

out_of_office_view

  1. Scroll through the office view to find the absence message if the user has set a long absence message.
  2. Show the vacation replacement only if the user has set one otherwise hide the view.
  3. Clicking on the vacation replacement user’s avatar/ name will allow you to join one-on-one conversation with the designated vacation replacement.
  4. Add start and end dates of vacation.
  5. If the user is out of office for only one day, display the message “User is out of office today” without showing the start and end dates of the vacation.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch force-pushed the out_of_office branch 4 times, most recently from ca9225d to a537694 Compare December 10, 2024 12:01
@sowjanyakch sowjanyakch marked this pull request as ready for review December 10, 2024 12:56
@sowjanyakch sowjanyakch self-assigned this Dec 10, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Dec 10, 2024
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Copy link
Contributor

@rapterjet2004 rapterjet2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  1. Is that the replacement views are still there even if I didn't set a replacement. This makes it seem like it's still loading even when they're not
    Screenshot 2024-12-13 at 7 46 17 AM

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4521-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings158158
Errors7272

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show "Out of office" message in 1-1 conversations
3 participants