Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(callbox): check if there are no participants in call #964

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 5, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Callbox all the time "You missed a call" notification
Call ringtone Normal beep

🚧 Tasks

  • Test

src/callbox/renderer/callbox.service.ts Outdated Show resolved Hide resolved
src/callbox/renderer/callbox.service.ts Show resolved Hide resolved
src/callbox/renderer/callbox.service.ts Outdated Show resolved Hide resolved
Copy link

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

- in that case call is already missed, and callbox shouldn't be shown

Signed-off-by: Maksim Sukharev <[email protected]>
…sed)

- if missed, don't show callbox, but native notification and default sound

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/961/handle-missed-calls branch from 683788b to cd85084 Compare December 6, 2024 12:48
@Antreesy Antreesy merged commit 0b907e0 into main Dec 6, 2024
10 checks passed
@Antreesy Antreesy deleted the fix/961/handle-missed-calls branch December 6, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants