Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrity): expect pkg mgmt files #488

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Sep 12, 2023

upgading to 27.1.0 RC3 failes because these files are included intentionally

building the phar files for me though managed to

@blizzz blizzz force-pushed the fix/noid/expect-packager-files branch from 434e951 to 94c444b Compare September 12, 2023 10:50
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry for missing that

@blizzz
Copy link
Member Author

blizzz commented Sep 12, 2023

Oh, sorry for missing that

Missed that, too, as i was looking for exclude lists, not allow lists. Even visited this repo :-/

@blizzz blizzz force-pushed the fix/noid/expect-packager-files branch from 94c444b to 7c58e2a Compare September 12, 2023 10:57
@blizzz
Copy link
Member Author

blizzz commented Sep 12, 2023

/backport to stable27

@blizzz blizzz modified the milestones: Nextcloud 27.1.0, Nextcloud 28 Sep 12, 2023
@blizzz blizzz merged commit 55eca48 into master Sep 12, 2023
21 checks passed
@blizzz blizzz deleted the fix/noid/expect-packager-files branch September 12, 2023 11:07
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@joshtrichards
Copy link
Member

joshtrichards commented Sep 17, 2023

These files also now exist in the v25.0.11 release artifact. Was that intentional? It appears to be causing issues like nextcloud/server#40456 since the updater in v25 doesn't have this awareness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants