Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused file version.php #530

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Remove unused file version.php #530

merged 1 commit into from
Jan 29, 2024

Conversation

come-nc
Copy link
Collaborator

@come-nc come-nc commented Jan 25, 2024

version.php contains a bogus version and is not used.
Actual version is in lib/Version.php.

@come-nc come-nc self-assigned this Jan 25, 2024
@joshtrichards
Copy link
Member

Oh I see!

It ends up in lib/Version.php at build time by way of buildVersionFile.php which provides the \NC\Updater\Version class used here.

I'd been meaning to look into the the build process for Updater more to try to document it for #503

Looks like a token file from the first release, hah. Actually, doesn't even look like it was used in 0.1 but probably always an accidental inclusion.

Glad to see some cleanup here, even if it's seemingly minor. :-)

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc merged commit 1bc942f into master Jan 29, 2024
23 checks passed
@come-nc come-nc deleted the fix/remove-unused-file branch January 29, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants