From 048abc90703d3413c3f438648463026156cc6005 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Tue, 13 Aug 2024 09:22:17 +0200 Subject: [PATCH 1/2] ci: Run cypress tests properly again on CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- .github/workflows/cypress.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index 909bfa4d0..f7396a89b 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -127,7 +127,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} SPLIT: ${{ matrix.total-containers }} - SPLIT_INDEX: ${{ matrix.containers == 'component' && 0 || matrix.containers }}``` + SPLIT_INDEX: ${{ matrix.containers == 'component' && 0 || matrix.containers }} - name: Upload snapshots uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4.3.4 From c233885bdd9f08ecd866b7b6be3de65d9071f784 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Tue, 13 Aug 2024 10:31:21 +0200 Subject: [PATCH 2/2] test(cypress): Fix download URL for public shares MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- cypress/e2e/sharing/download-share.cy.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cypress/e2e/sharing/download-share.cy.ts b/cypress/e2e/sharing/download-share.cy.ts index 55facd0f9..faed8d555 100644 --- a/cypress/e2e/sharing/download-share.cy.ts +++ b/cypress/e2e/sharing/download-share.cy.ts @@ -89,14 +89,14 @@ describe(`Download ${fileName} from viewer in link share`, function() { it('See the full screen and download icons in the menu', function() { cy.get('body > .v-popper__popper ul span.fullscreen-icon').should('be.visible') - cy.get(`body > .v-popper__popper ul a.action-link[href*='/s/${token}/download']`).should('be.visible') + cy.get(`body > .v-popper__popper ul a.action-link[href*='/public.php/dav/files/${token}/image1.jpg']`).should('be.visible') }) it('Download the image', function() { // https://github.com/cypress-io/cypress/issues/14857 cy.window().then((win) => { setTimeout(() => { win.location.reload() }, 5000) }) // download the file - cy.get(`body > .v-popper__popper a.action-link[href*='/s/${token}/download']`).click() + cy.get(`body > .v-popper__popper ul a.action-link[href*='/public.php/dav/files/${token}/image1.jpg']`).click() }) it('Compare downloaded file with asset by size', function() {