Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow viewing versions #1469

Closed
juliusknorr opened this issue Nov 16, 2022 · 9 comments
Closed

Allow viewing versions #1469

juliusknorr opened this issue Nov 16, 2022 · 9 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Nov 16, 2022

Is your feature request related to a problem? Please describe.
Currently versions can only be downloaded in the files app, so a user will need to open them locally in order to see what the state of the file is.

Describe the solution you'd like
The viewer app should be able to handle opening specific versions of a file. This should be already possible from the backend side as the versions are exposed as a WebDAV collection. The version is identified by the file id and their timestamp, after that the file can be downloaded through:

/remote.php/dav/versions/julius/versions/6713781/1668462795

The version to load (timestamp) could become an additional parameter on the open() call:

open({ path, fileInfo, list = [], loadMore = () => ([]), canLoop = true, onPrev = () => {}, onNext = () => {}, onClose = () => {} } = {}) {

Then this version could get passed to any mimetype handler.

Related to ongoing server development in nextcloud/server#34769

cc @skjnldsv @nextcloud/office

@juliusknorr juliusknorr added enhancement New feature or request 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Nov 16, 2022
@juliusknorr juliusknorr moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Nov 16, 2022
@skjnldsv
Copy link
Member

I initially planned to cover that by forcing the use of the new File API to open Viewer (for 26)
With this we would load the source straight away if the preview is not existing/defined

@skjnldsv
Copy link
Member

Since that would be a breaking change, 26 would be nice for a Viewer 2.0.0

@skjnldsv
Copy link
Member

If your team have room to push this forward, we can team up to plan this accordingly :)

@juliusknorr
Copy link
Member Author

Sounds good, thanks. I'll align on the priorities and then reach out to you in case we pick that up.

@juliusknorr juliusknorr self-assigned this Nov 16, 2022
@skjnldsv
Copy link
Member

So you know, I already started this work a few weeks ago. But didn't continue because other priorities came up.

@PVince81
Copy link
Member

PVince81 commented Dec 22, 2022

to dodge the breaking change maybe we can first add a second method with the new API and leave the old one with an adapter to give app devs more time to migrate, and we could deprecate for NC 27 (add a deprecation note in NC 26 that we'll remove to NC 27)

@PVince81
Copy link
Member

@juliushaertl is this something the office team would take over ?

@juliusknorr
Copy link
Member Author

Generally yes, but we currently don't have it scheduled due to other tasks with higher prio.

@juliusknorr juliusknorr removed their assignment Feb 21, 2023
@juliusknorr
Copy link
Member Author

Was done with nextcloud/server#39171

@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation (don't pick) to ☑️ Done in 📝 Office team Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants