Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(video): video fullscreen on ios devices #2074

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix(video): video fullscreen on ios devices #2074

merged 1 commit into from
Nov 29, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Nov 23, 2023 •
edited
Loading

This has been tested on an iPhone, an iPad and in the browser. It now works on iPhone and there are no regressions on the other tested devices.

Before

Landscape Portrait
before-landscape before-portrait

After

Landscape Portrait
IMG_2675 IMG_2674

@st3iny st3iny added bug Something isn't working regression Regression of a previous working feature 2. developing Work in progress labels Nov 23, 2023
@st3iny st3iny self-assigned this Nov 23, 2023
@st3iny st3iny force-pushed the fix/videos/ios-native-full-screen branch from ef5e8c3 to ad76d4b Compare November 29, 2023 11:38
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 29, 2023
@st3iny st3iny requested a review from artonge November 29, 2023 11:53
@st3iny st3iny added this to the Nextcloud 29 milestone Nov 29, 2023
@st3iny st3iny marked this pull request as ready for review November 29, 2023 11:53
@st3iny
Copy link
Member Author

st3iny commented Nov 29, 2023

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Nov 29, 2023
@st3iny
Copy link
Member Author

st3iny commented Nov 29, 2023

/backport to stable27

@st3iny
Copy link
Member Author

st3iny commented Nov 29, 2023

/backport to stable26

@st3iny st3iny requested review from skjnldsv and szaimen November 29, 2023 11:55
szaimen
szaimen approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have an iphone so cannot test but heard that it works so fine by me

@ChristophWurst ChristophWurst merged commit 6c2b807 into master Nov 29, 2023
29 checks passed
@ChristophWurst ChristophWurst deleted the fix/videos/ios-native-full-screen branch November 29, 2023 15:02
@ChristophWurst
Copy link
Member

but heard that it works so fine by me

the rumor spread quickly

This was referenced Nov 29, 2023
Merged
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Nov 29, 2023
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@st3iny @ChristophWurst @artonge @szaimen