Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable view file in trashbin #2093

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: Disable view file in trashbin #2093

merged 2 commits into from
Dec 7, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 5, 2023

Viewer was not implemented for deleted files intentionally so we disable viewer for deleted files to prevent unintended behaviour

@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews labels Dec 5, 2023
@Pytal Pytal added this to the Nextcloud 29 milestone Dec 5, 2023
@Pytal Pytal self-assigned this Dec 5, 2023
@AndyScherzinger

This comment was marked as outdated.

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Dec 5, 2023
@AndyScherzinger AndyScherzinger mentioned this pull request Dec 5, 2023
5 tasks
@Pytal
Copy link
Member Author

Pytal commented Dec 5, 2023

/backport to stable28

#2094 ;)

@Pytal

This comment was marked as outdated.

@Pytal Pytal force-pushed the fix/trashbin-action branch from 3fba91d to aa46848 Compare December 5, 2023 23:19
@Pytal

This comment was marked as resolved.

@Pytal Pytal force-pushed the fix/trashbin-action branch from a7b2600 to a430c39 Compare December 5, 2023 23:36
src/views/Viewer.vue Outdated Show resolved Hide resolved
@Pytal Pytal force-pushed the fix/trashbin-action branch from a430c39 to 6f15986 Compare December 6, 2023 19:06
@Pytal

This comment was marked as resolved.

@Pytal Pytal requested a review from skjnldsv December 6, 2023 19:08
@Pytal Pytal force-pushed the fix/trashbin-action branch from 6f15986 to d3dfb79 Compare December 6, 2023 19:12
@Pytal
Copy link
Member Author

Pytal commented Dec 6, 2023

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv merged commit 979c541 into master Dec 7, 2023
27 checks passed
@skjnldsv skjnldsv deleted the fix/trashbin-action branch December 7, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Clicking on deleted file in trash bin leads nowhere
4 participants