Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add live photo support based on files metadata #2103

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Add live photo support based on files metadata #2103

merged 3 commits into from
Jan 18, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Dec 20, 2023 •
edited
Loading

Screencast.from.2024-01-03.16-41-43.webm

Part of nextcloud/server#40244

@artonge artonge added enhancement New feature or request 3. to review Waiting for reviews javascript Javascript related ticket labels Dec 20, 2023
@artonge artonge added this to the Nextcloud 29 milestone Dec 20, 2023
@artonge artonge requested a review from skjnldsv December 20, 2023 14:13
@artonge artonge self-assigned this Dec 20, 2023
@artonge artonge requested a review from nimishavijay December 20, 2023 14:14
ShGKme
ShGKme reviewed Dec 20, 2023
View reviewed changes
src/components/Images.vue Outdated Show resolved Hide resolved
@artonge artonge force-pushed the artonge/feat/live_photo branch 2 times, most recently from 0179edf to 8538515 Compare December 20, 2023 17:05
@artonge
Copy link
Contributor Author

artonge commented Dec 21, 2023

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Dec 21, 2023
nimishavijay
nimishavijay approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As a follow up, there could be a fade as a transition, instead of it changing instantly :)

nimishavijay
nimishavijay reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally: the "LIVE" text looks like it's in a thin or light font, which is something we don't use. If it's light font, then it should be changed to regular :)

@artonge artonge force-pushed the artonge/feat/live_photo branch 2 times, most recently from 6e6ad64 to cfcb577 Compare January 3, 2024 16:36
skjnldsv
skjnldsv reviewed Jan 3, 2024
View reviewed changes
src/components/Images.vue Outdated Show resolved Hide resolved
@artonge
Copy link
Contributor Author

artonge commented Jan 3, 2024

Additionally: the "LIVE" text looks like it's in a thin or light font, which is something we don't use. If it's light font, then it should be changed to regular :)

The screencast was a bit old, I updated it. Should be fine now :)

skjnldsv
skjnldsv reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@artonge artonge force-pushed the artonge/feat/live_photo branch from cfcb577 to a00e1ec Compare January 3, 2024 16:54
@artonge artonge requested a review from skjnldsv January 4, 2024 09:24
@artonge artonge force-pushed the artonge/feat/live_photo branch 4 times, most recently from bf710a3 to 859efbf Compare January 4, 2024 16:49
@artonge
Copy link
Contributor Author

artonge commented Jan 4, 2024

/compile /

@artonge artonge force-pushed the artonge/feat/live_photo branch from 9b80d06 to 21dd38f Compare January 10, 2024 16:01
@artonge artonge changed the title Add live photo support base on files metadata Add live photo support based on files metadata Jan 17, 2024
@artonge artonge force-pushed the artonge/feat/live_photo branch from 21dd38f to 8fdcca1 Compare January 17, 2024 14:56
@artonge
Copy link
Contributor Author

artonge commented Jan 17, 2024

@skjnldsv thanks for the feedback.

  1. Was also an issue on master, I fixed it here anyway. It was probably due to an update of @nc/files that change which properties are public.
  2. Indeed, bad copy and past from me. It's fixed now.

@artonge artonge requested a review from skjnldsv January 17, 2024 14:59
@artonge
Copy link
Contributor Author

artonge commented Jan 17, 2024

Also pushed a note for the "LIVE" label as asked, thanks to your work :)

@artonge artonge force-pushed the artonge/feat/live_photo branch 2 times, most recently from 7ad26ef to 3020551 Compare January 17, 2024 15:09
artonge and others added 3 commits January 18, 2024 09:09
@artonge
Add live photo support base on files metadata
0bb0409 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
Improve handling of Node API properties
1521617 
Signed-off-by: Louis Chemineau <[email protected]>
@nextcloud-command @artonge
chore(assets): Recompile assets
c63de6d 
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/live_photo branch from 3020551 to c63de6d Compare January 18, 2024 08:09
@artonge artonge merged commit 811cff9 into master Jan 18, 2024
32 checks passed
@artonge artonge deleted the artonge/feat/live_photo branch January 18, 2024 08:25
@backportbot-nextcloud

This comment was marked as outdated.

Sign in to view
@artonge

This comment was marked as off-topic.

Sign in to view
@artonge

This comment was marked as outdated.

Sign in to view
@backportbot-nextcloud

This comment was marked as outdated.

Sign in to view
@artonge

This comment was marked as off-topic.

Sign in to view
@artonge
Copy link
Contributor Author

artonge commented Jan 18, 2024

/backport 0bb0409 to stable28

@artonge

This comment was marked as outdated.

Sign in to view
@backportbot-nextcloud

This comment was marked as outdated.

Sign in to view
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 18, 2024
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Jan 18, 2024
@artonge

This comment was marked as outdated.

Sign in to view
@artonge

This comment was marked as outdated.

Sign in to view
@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 18, 2024
@backportbot-nextcloud

This comment was marked as outdated.

Sign in to view
@artonge artonge mentioned this pull request Jan 18, 2024
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay approved these changes

@ShGKme ShGKme ShGKme left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot enhancement New feature or request javascript Javascript related ticket
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
5 participants
@artonge @skjnldsv @ShGKme @nimishavijay @nextcloud-command