Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image viewer modal no longer closes when clicking out of image #2166

Open
valdearg opened this issue Feb 15, 2024 · 4 comments
Open

Image viewer modal no longer closes when clicking out of image #2166

valdearg opened this issue Feb 15, 2024 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working regression Regression of a previous working feature

Comments

@valdearg
Copy link

valdearg commented Feb 15, 2024 •
edited
Loading

Describe the bug
When opening an image in the slideshow modal, clicking outside the image no longer closes the image. This is the same issue as in #646 that's snuck in.

To Reproduce
Open image, click outside the image but not where the arrows are. Previously the image would be closed, now it doesn't.

Expected behaviour
Image should be closed and returned to the previous page.

Screenshots
image

Clicking outside the image, but not on the image or arrows would close the image.

Desktop (please complete the following information):

  • OS: Windows 11 Pro 22H2
  • Browser: Chrome
  • Version: 121.0.6167.185 (Official Build) (64-bit)
  • Browser: Firefox
  • Version: 122.0.1 (64-bit)
@valdearg valdearg added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Feb 15, 2024
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Feb 16, 2024
@skjnldsv
Copy link
Member

What Nextcloud version @valdearg ? :)

@valdearg
Copy link
Author

valdearg commented Feb 16, 2024 •
edited
Loading

Sorry, this would've been helpful information, wouldn't it!

I'm on version NextCloud version 28.0.2 and this issue only started when updated from 28.0.1.1 to 28.0.2

@skjnldsv
Copy link
Member

probably from #2127
cc @artonge

@valdearg
Copy link
Author

Any movement on this one, @skjnldsv / @artonge ? Issue still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valdearg @skjnldsv