Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check compatibility with OASIS coupler #5

Open
athelaf opened this issue Aug 8, 2022 · 4 comments
Open

Check compatibility with OASIS coupler #5

athelaf opened this issue Aug 8, 2022 · 4 comments
Assignees
Labels
discussion Topic for discussion

Comments

@athelaf
Copy link
Collaborator

athelaf commented Aug 8, 2022

The OASIS coupler (see documentation, Section 2.2.3) supports 5 types of grid partitioning, including the Box partition approach we use in our domain decomposition. The definition of the boxes is similar, i.e., each partition is described by its upper left corner and its local extents in the X and Y dimensions, where X is the first dimension and Y is the second. However, in our tool the upper left corner is described by coordinates, assuming Y is the fastest increasing dimension (our tool uses C-compatible ordering internally), while in OASIS it is described by a single global offset, assuming X is the fastest increasing dimension (OASIS uses Fortran-compatible ordering internally). An example of a box partition over 3 processes for OASIS is shown below:
Screenshot from 2022-08-09 10-17-49

@athelaf athelaf changed the title Provide all the information required for OASIS coupler Check compatibility with OASIS coupler Aug 9, 2022
@athelaf athelaf added the discussion Topic for discussion label Aug 12, 2022
@athelaf athelaf moved this to Discussion in neXtSIM_DG overview Aug 22, 2022
@jwallwork23 jwallwork23 self-assigned this Aug 20, 2024
@jwallwork23
Copy link
Contributor

Related to nextsimhub/nextsimdg#640.

@jwallwork23 jwallwork23 moved this from Discussion to In Progress in neXtSIM_DG overview Aug 20, 2024
@jwallwork23
Copy link
Contributor

See issue5_oasis-compat for work in progress.

@TomMelt
Copy link
Contributor

TomMelt commented Oct 28, 2024

I recently refactored (#59) and modified the internal ordering (#58) so that we could be compatible both with the nextsimDG and OASIS coupler. One thing I am not sure of, in the above diagram (and those in the OASIS docs), where is the coordinate system origin i.e., x=0, y=0. My current understanding is that (0,0) is the top-left corner. If that is the case, then I believe the new implementation ( as written in PR #58) will give the correct compatibility.

If (0,0) is not the top left corner (in the diagram) then we potentially have a problem.

@jwallwork23
Copy link
Contributor

I recently refactored (#59) and modified the internal ordering (#58) so that we could be compatible both with the nextsimDG and OASIS coupler. One thing I am not sure of, in the above diagram (and those in the OASIS docs), where is the coordinate system origin i.e., x=0, y=0. My current understanding is that (0,0) is the top-left corner. If that is the case, then I believe the new implementation ( as written in PR #58) will give the correct compatibility.

If (0,0) is not the top left corner (in the diagram) then we potentially have a problem.

The fact that proc 1 in the diagram is positioned in the top left is encouraging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Topic for discussion
Projects
None yet
Development

No branches or pull requests

4 participants