You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there is only 1 Dispatcher - The Dispatcher.
It has no specific typing except for the event name, other than that its *args: Any, **kwargs: Any which kind of makes sense for gateway opcode events & gateway DISPATCH events. (as manually filtering this yourself is stupid)
I don't have any specific ideas for improvement for opcode events and DISPATCH events, however for events nextcore produces, using vauge and dynamic typing is stupid.
I propose something like this (No clue about class name
d: Dispatcher2[EventType1, EventType2] =Dispatcher2()
@d.listen()asyncdefall_events(event: EventType1|EventType2): # Or just realistically use typing.Any
...
@d.listen(EventType1)asyncdefone_event(event: EventType1):
...
This avoids reading typehints - which I do not want in this library, as it is "magic".
The text was updated successfully, but these errors were encountered:
What about calling the new dispatcher TypedDispatcher since it has more specific typing? Alternatively, the current dispatcher could be renamed RawDispatcher, but that would obviously be a breaking change.
Currently there is only 1 Dispatcher - The Dispatcher.
It has no specific typing except for the event name, other than that its
*args: Any, **kwargs: Any
which kind of makes sense for gateway opcode events & gateway DISPATCH events. (as manually filtering this yourself is stupid)I don't have any specific ideas for improvement for opcode events and DISPATCH events, however for events nextcore produces, using vauge and dynamic typing is stupid.
I propose something like this (No clue about class name
This avoids reading typehints - which I do not want in this library, as it is "magic".
The text was updated successfully, but these errors were encountered: