Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the aoqn, which didn't work, with aoqn #668

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ashotmarg
Copy link
Contributor


name: Correct config file
about: Correction in the existing config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml

@ashotmarg ashotmarg requested a review from jfy133 April 15, 2024 19:57
@ashotmarg
Copy link
Contributor Author

Hi @jfy133 , sorry, I have to bug you with this again. For some weird reason the second 'whoami' command substitution doesn't actually work, i.e., i get the literal 'whoami'... So, I guess I either had to create extra groovy variable to extract the username and pass to the cacheDir, or just use the ${USER}, which is working.

@jfy133
Copy link
Member

jfy133 commented Apr 16, 2024

I think in this case it's safer to use something like @nvnieuwk does at Ghent:

def tier1_project = System.getenv("SBATCH_ACCOUNT") ?: System.getenv("SLURM_ACCOUNT")

Maybe there is a system function to get the output of commands so you can run whoami?

@ashotmarg
Copy link
Contributor Author

Yeah, there seem to be few other ways of doing this in groovy, but perhaps in this case just the plain ${USER} is more straightforward.

@ashotmarg ashotmarg merged commit 59ac7ec into nf-core:master Apr 16, 2024
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants