Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unc lccc instituational profile #542

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Conversation

dmarron
Copy link
Contributor

@dmarron dmarron commented Aug 22, 2023


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any
  • Requested review from @nf-core/maintainers and/or #request-review on slack

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nf-core-bot fix linting

Can be merged once prettier fixed

docs/unc_lccc.md Outdated Show resolved Hide resolved
@jfy133
Copy link
Member

jfy133 commented Aug 22, 2023

Also are you Alan Hoyle (just to check, not sure if dmarron is a short name or just a handle, sorry!) or is he the sys admin responsible for the profile?

@dmarron
Copy link
Contributor Author

dmarron commented Aug 22, 2023

Also are you Alan Hoyle (just to check, not sure if dmarron is a short name or just a handle, sorry!) or is he the sys admin responsible for the profile?

No, I am David Marron, but Alan Hoyle is responsible for this profile.

@jfy133
Copy link
Member

jfy133 commented Aug 23, 2023

Ok cool, I think you're good to go still - just need to run prettier on the markdown file (can't do that from my phone unfortunately, and for some reason the bit didn't work....) Probably just a trailing whitespace at the end of one of the lines

@dmarron dmarron merged commit 635c546 into nf-core:master Aug 23, 2023
@dmarron dmarron deleted the unc_lccc branch August 23, 2023 13:03
@alanhoyle
Copy link
Contributor

alanhoyle commented Aug 24, 2023

@jfy133: @dmarron and I work together on the LCCC Nextflow workflows. I wrote the inital draft and he did the checks, updates, and documentation before submitting. Thanks for the sanity check.

@jfy133
Copy link
Member

jfy133 commented Aug 24, 2023

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants